Only create the ChargeableField if we plan to use it

ManageIQ · Aug 7, 2018 · b234145 · b234145
1 parent 7b1d5e1
commit b234145
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/db/migrate/20171026103833_add_cores_allocated_rate_detail.rb b/db/migrate/20171026103833_add_cores_allocated_rate_detail.rb
@@ -16,14 +16,15 @@ class ChargebackRateDetail < ActiveRecord::Base
   end
 
   def up
+    rate_detail_template = ChargebackRateDetail.where(:description => "Allocated CPU Count").first
+    return if rate_detail_template.nil? # No rates that need this detail.
+    rate_detail_template = rate_detail_template.dup
+
     chargeable_field = ChargeableField.find_or_create_by(:metric      => "derived_vm_numvcpu_cores",
                                                          :description => "Allocated CPU Cores",
                                                          :group       => "cpu_cores",
                                                          :source      => "allocated")
 
-    rate_detail_template = ChargebackRateDetail.where(:description => "Allocated CPU Count").first
-    return if rate_detail_template.nil? # No rates that need this detail.
-    rate_detail_template = rate_detail_template.dup
     rate_detail_template.chargeable_field = chargeable_field
     rate_detail_template.description = "Allocated CPU Cores"
     rate_detail_template.per_unit = "cpu core"