Friendly error message for HTTP 503 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling HTML error responses from undercloud Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1566570 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1510769
slemrmartin
force-pushed
the
neutron-svc-off-message
branch
from
14dc88d to
0c34c37
Compare
|
Checked commit slemrmartin@0c34c37 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks pretty good to me. Have you tested it to ensure it works? |
|
@miq-bot add_label documentation |
|
@miq-bot remove_label documentation |
|
@miq-bot add_label blocker |
|
@mansam Yes, I have. It was the hardest part to get credentials to this environment :) |
|
@slemrmartin thanks! |
simaishi
pushed a commit
that referenced
this pull request
May 21, 2018
Friendly error message for HTTP 503 (cherry picked from commit 1afb38f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1566570
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling HTML error responses from undercloud
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1566570
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1510769
Steps to reproduce:
In Networks -> Networks:
Actual results:
unexpected token at '<html><body><h1>503 Service Unavailable</h1> No server is available to handle this request. </body></html> 'Expected results:
503 Service Unavailable No server is available to handle this request.@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
Cc @Ladas, @aufi