Fixes unfriendly message when adding network for unavailable provider

[slemrmartin]

Create/Update/Delete Cloud Network caused unfriendly message when provider unavailable (fix)

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1510769
@miq-bot add_label bug
Cc @Ladas

Steps to reproduce:

In Networks -> Networks:

1. Click Configure / Add a new Cloud Network
2. Choose Network manager of unavailable provider (_OpenStack / Ovirt only _)
3. Fill required fields and click Add

Actual results:
Unfriendly error message. ("undefined method `response' for <...> Did you mean? respond_to?")

Expected results:
Message should be friendly.

[miq-bot]

Checked commit slemrmartin@0bbc144 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[mansam]

+1 Looks like a fine fix, but I do have to wonder why it's even possible to choose unavailable providers :)

[slemrmartin]

That's because provider can become unavailable (maitenance, some newly installed proxy, bad configured firewall etc.). And there is no validation of all providers each time you want add network (only for making select items list)

[Ladas]

👍

[simaishi]

@slemrmartin Can this be gaprindashvili/yes ?

[slemrmartin]

can be
@miq-bot add_label gaprindashvili/yes

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 48bead6e50cf6aab1404848fd6ff33e4360c61a1
Author: Samuel Lucidi <[email protected]>
Date:   Wed Apr 4 11:05:56 2018 -0400

    Merge pull request #264 from slemrmartin/unavailable-network-provider-message
    
    Fixes unfriendly message when adding network for unavailable provider
    (cherry picked from commit e093c84b6625827f6709f7e6bff515c035b7ac48)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1566570