VCR updates for tests in kubernetes repo #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cben
changed the title
Default sort was by hash, inconvenient. (and sorted existing .txt so next VCR diff is easy to read)
Add PVs, claim them with PVCs (deterministic 1:1 by label selector), use them in a pod.
cben
force-pushed
the
vcr-for-kubernetes-too
branch
3 times, most recently
from
f401f38 to
ef22fe5
Compare
cben
changed the title
|
@zeari @yaacov @moolitayer PTAL, this now has all I want. |
moolitayer
reviewed
Jan 25, 2018
| oc get persistentVolumes --show-labels | ||
| echo | ||
| echo "== oc get persistentvolumeclaims --all-namespaces --show-kind --show-labels ==" | ||
| oc get persistentVolumeClaims --all-namespaces --show-labels |
There was a problem hiding this comment.
We have a diff of --show-kind in the three echo statements above. seems helpful to include, event if we are only showing one object kind at a time.
cben
force-pushed
the
vcr-for-kubernetes-too
branch
from
ef22fe5 to
891e243
Compare
|
Done, PTAL. |
moolitayer
reviewed
Jan 28, 2018
| @@ -96,12 +114,26 @@ oc label route my-route-2 key-route-label- | |||
| oc patch --type=merge template my-template-2 --patch='{"parameters": []}' | |||
| oc delete pod my-pod-2 | |||
|
|
|||
| #old_quotas=$("oc describe quota | |||
- Add a memory quota to test binary suffixes (Mi, Gi). - Delete all quotas from my-project-1 before 2nd recording, as test expects. - Modify quota items for 2nd recording to cover delete, update, no-change. https://bugzilla.redhat.com/show_bug.cgi?id=1504560
Currently ignored for `oc get images` but let's specify anyway.
var=$(cmd) exit status is cmd exit status. export ... exit status is always 0. See https://stackoverflow.com/a/48486983/239657.
…unts The default PVs are HostPath to /var/lib/minishift/openshift.local.pv/pv0089 etc.
cben
force-pushed
the
vcr-for-kubernetes-too
branch
from
891e243 to
99ac35b
Compare
|
Checked commits cben/manageiq-providers-openshift@4dc5914~...99ac35b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
this one good to go.
|
cben
added a commit
to cben/guides
that referenced
this pull request
Jan 29, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 22, 2018
VCR updates for tests in kubernetes repo (cherry picked from commit 542fa53) https://bugzilla.redhat.com/show_bug.cgi?id=1559544
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer rely on hawkular metrics for example of volumes.
Defined PVs, PVCs (successfully bound and pending), and referenced PVC in pod.
Recorded without
--metrics=> minishift used ~2GB RAM instead of ~5GB 📉Modify quotas between runs.
https://bugzilla.redhat.com/show_bug.cgi?id=1504560
@miq-bot add-label test, gaprindashvili/yes
@zeari @yaacov @moolitayer please review (recommend by commits), together with ManageIQ/manageiq-providers-kubernetes#216