Openshift VCR-recording script, touch up minishift instructions. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use fixed dir also used by `minishift addons install --defaults` - Use gist URL that works both for git clone and browser.
|
@enoodle @moolitayer please review |
|
@zeari please review |
zeari
reviewed
Jan 11, 2018
providers/openshift.md
Outdated
| $ minishift addons enable manageiq | ||
| ``` | ||
|
|
||
| 3. Start minishift: | ||
| 2. Start minishift: | ||
|
|
||
| ```console | ||
| $ minishift start --vm-driver virtualbox --openshift-version "v1.5.0-rc.0" |
There was a problem hiding this comment.
updated to v3.6.1 which is what I used to record currently.
doesn't matter much, there is a link couple lines below to all valid docker tags.
zeari
approved these changes
Jan 11, 2018
|
@agrare @blomquisg please review/merge (not sure who are maintainers in this repo) |
|
/cc @Fryguy |
|
Updated per ManageIQ/manageiq-providers-openshift#83. @chessbyte @Fryguy Who can merge PRs in this repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups from ManageIQ/manageiq-providers-openshift#75