Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tower credential types #9

Merged
merged 12 commits into from
Jul 12, 2017
Merged

New Tower credential types #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
64aaae7
NetworkCredential
jameswnl Jun 13, 2017
9d9f49b
OpenstackCredential
jameswnl Jun 13, 2017
2fd7939
GoogleCredential
jameswnl Jun 13, 2017
6747d39
RackspaceCredential
Jun 23, 2017
525e24d
Azure(RM)Credential
Jun 23, 2017
6e23557
Satellite(6)Crendential
Jun 23, 2017
2b8d9ad
credential fields hint text update
Jun 23, 2017
5a863e3
spec tests for credential refresh
jameswnl Jun 15, 2017
4b84564
spec helper rake task add new credential type objects
Jun 27, 2017
61523b5
update cassette and corresponding spec
Jun 27, 2017
2fc5ff8
remove ActivieSupport:Concern from credentials
Jul 5, 2017
80c24ce
Workaround for a test failure caused by https://github.com/ansible/an…
Jul 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/manageiq/providers/ansible_tower/automation_manager/openstack_credential.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
class ManageIQ::Providers::AnsibleTower::AutomationManager::OpenstackCredential < ManageIQ::Providers::AnsibleTower::AutomationManager::CloudCredential
include ManageIQ::Providers::AnsibleTower::Shared::AutomationManager::OpenstackCredential
end
49 changes: 49 additions & 0 deletions ...models/manageiq/providers/ansible_tower/shared/automation_manager/openstack_credential.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
module ManageIQ::Providers::AnsibleTower::Shared::AutomationManager::OpenstackCredential
extend ActiveSupport::Concern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are following the pattern in the other credential modules, but why is AS::Concern used here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


COMMON_ATTRIBUTES = {
:userid => {
:label => N_('Username'),
:help_text => N_('Username for this credential'),
:required => true
},
:password => {
:type => :password,
:label => N_('Password (API Key)'),
:help_text => N_('Password for this credential'),
:required => true
}
}.freeze

EXTRA_ATTRIBUTES = {
:host => {
:type => :string,
:label => N_('Host (Authentication URL'),
:help_text => N_('The host to authenticate with. For example, https://openstack.business.com/v2.0'),
:max_length => 1024,
:required => true
},
:project => {
:type => :string,
:label => N_('Project (Tenant Name)'),
:help_text => N_('This is the tenant name. This value is usually the same as the username'),
:max_length => 100,
:required => true
},
:domain => {
:type => :string,
:label => N_('Domain Name'),
:help_text => N_('OpenStack domains define administrative boundaries. It is only needed for Keystone v3 authentication URLs'),
:max_length => 100
}
}.freeze

API_ATTRIBUTES = COMMON_ATTRIBUTES.merge(EXTRA_ATTRIBUTES).freeze

API_OPTIONS = {
:type => 'cloud',
:label => N_('OpenStack'),
:attributes => API_ATTRIBUTES
}.freeze
TOWER_KIND = 'openstack'.freeze
end