New Tower credential types #9

jameswnl · 2017-06-27T18:32:12Z

Make MIQ's support to be on par with what Tower supports.

https://www.pivotaltracker.com/story/show/148234657

Created https://bugzilla.redhat.com/show_bug.cgi?id=1478898 for backporting to fine

jameswnl · 2017-06-29T01:12:50Z

@miq-bot remove_label wip

bronaghs · 2017-07-03T14:14:14Z

hey @durandom - Can you please review this? Danke!

durandom

LGTM 👍
some question, but minor

durandom · 2017-07-05T09:24:13Z

app/models/manageiq/providers/ansible_tower/shared/automation_manager/openstack_credential.rb

@@ -0,0 +1,49 @@
+module ManageIQ::Providers::AnsibleTower::Shared::AutomationManager::OpenstackCredential
+  extend ActiveSupport::Concern


I see you are following the pattern in the other credential modules, but why is AS::Concern used here?

durandom · 2017-07-05T09:27:10Z

lib/tasks_private/spec_helper.rake

@@ -80,6 +80,37 @@ class PopulateTower
  end

  def create_dataset
+
+    ssh_key_data = <<~HEREDOC
+    -----BEGIN RSA PRIVATE KEY-----


thanks for sharing you private ssh key 😈

you are welcome. generated for this particular purpose only 😄

durandom · 2017-07-05T09:36:35Z

spec/support/ansible_shared/automation_manager/refresher.rb

@@ -100,12 +100,12 @@
  def assert_counts
    expect(Provider.count).to                                 eq(1)
    expect(automation_manager).to                             have_attributes(:api_version => "3.0.1")
-    expect(automation_manager.configured_systems.count).to    eq(130)


these counts are a pain.
in aws we changed this to get the counts straight from the API and just assert they are equal to objects counts in the DB.

You would access the API easily via automation_manager.provider.connect.hosts.count
Maybe add a safe trap, that the numbers are non-zero

yeah, was actually considering this. but thinking of using the Faraday direct call to avoid depending on the Ansible Tower Gem. What do you think?
automation_manager.provider.connect.hosts.count would be much more straightforward.

@durandom let's keep this as is for now. There's some strange issue with the Tower we have been using to perform this test.

(The reported count of hosts is more than the actual hosts returned)

The reported count of hosts is more than the actual hosts returned

🤔

If you have some spare time 😆 maybe you want to add a docker run for setting up a tower and populating it?

I did and ended up aborting it because it needs enterprise license to support survey spec.

…ruby#95

miq-bot · 2017-07-11T13:39:28Z

Some comments on commits https://github.com/jameswnl/manageiq-providers-ansible_tower/compare/64aaae7bd1c7d1f5ff2019207ded963da351aedf~...80c24cecbf9653bd72e82c6b9b1533547b6dc4ac

spec/vcr_cassettes/manageiq/providers/ansible_tower/automation_manager/refresher.yml

💣 💥 🔥 🚒 - 1768 - Detected cfme

miq-bot · 2017-07-11T13:39:29Z

Checked commits https://github.com/jameswnl/manageiq-providers-ansible_tower/compare/64aaae7bd1c7d1f5ff2019207ded963da351aedf~...80c24cecbf9653bd72e82c6b9b1533547b6dc4ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
18 files checked, 52 offenses detected

app/models/manageiq/providers/ansible_tower/shared/automation_manager/azure_credential.rb

❗ - Line 10, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 22, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 28, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 34, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 3, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 4, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 5, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 8, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 9, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/models/manageiq/providers/ansible_tower/shared/automation_manager/google_credential.rb

❗ - Line 13, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 14, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 15, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 16, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 19, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/models/manageiq/providers/ansible_tower/shared/automation_manager/network_credential.rb

app/models/manageiq/providers/ansible_tower/shared/automation_manager/openstack_credential.rb

❗ - Line 17, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 31, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 3, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/models/manageiq/providers/ansible_tower/shared/automation_manager/rackspace_credential.rb

❗ - Line 3, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/models/manageiq/providers/ansible_tower/shared/automation_manager/satellite6_credential.rb

❗ - Line 10, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 11, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 12, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 3, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 4, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 5, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 6, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
❗ - Line 9, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

lib/tasks_private/spec_helper.rake

💣 💥 🔥 🚒 - Line 101, Col 39 - Syntax - unexpected token tIDENTIFIER
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 109, Col 25 - Syntax - unexpected token tCONSTANT
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 111, Col 10 - Syntax - unexpected token klEND
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 84, Col 20 - Syntax - unexpected token tLSHFT
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 85, Col 10 - Syntax - unexpected token klBEGIN
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 88, Col 58 - Syntax - unexpected token tCONSTANT
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 92, Col 65 - Syntax - unexpected token tIDENTIFIER
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
💣 💥 🔥 🚒 - Line 97, Col 6 - Syntax - unexpected token tCONSTANT
(Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)

jameswnl · 2017-07-12T15:25:03Z

@miq-bot add_labels fine/yes

ManageIQ/manageiq-providers-ansible_tower#9

simaishi · 2017-08-04T19:25:01Z

@jameswnl Is there a BZ for this? Can you please create if it doesn't exist?

simaishi · 2017-11-28T17:12:21Z

Backported to Fine via ManageIQ/manageiq#15780

jameswnl and others added 7 commits June 23, 2017 11:59

NetworkCredential

64aaae7

OpenstackCredential

9d9f49b

GoogleCredential

2fd7939

RackspaceCredential

6747d39

Azure(RM)Credential

525e24d

Satellite(6)Crendential

6e23557

credential fields hint text update

2b8d9ad

miq-bot added the wip label Jun 27, 2017

jameswnl and others added 3 commits June 27, 2017 15:33

spec tests for credential refresh

5a863e3

spec helper rake task add new credential type objects

4b84564

update cassette and corresponding spec

61523b5

bronaghs mentioned this pull request Jun 28, 2017

[WIP] New credentials #7

Closed

jameswnl changed the title ~~[WIP] New Tower credential types~~ New Tower credential types Jun 29, 2017

miq-bot removed the wip label Jun 29, 2017

bronaghs requested a review from durandom July 3, 2017 14:13

durandom approved these changes Jul 5, 2017

View reviewed changes

James Wong and others added 2 commits July 5, 2017 15:55

remove ActivieSupport:Concern from credentials

2fc5ff8

Workaround for a test failure caused by ansible/ansible_tower_client_…

80c24ce

…ruby#95

jameswnl mentioned this pull request Jul 11, 2017

method_missing for missing attr ansible/ansible_tower_client_ruby#96

Closed

blomquisg merged commit 530ae10 into ManageIQ:master Jul 12, 2017

blomquisg added the enhancement label Jul 12, 2017

blomquisg added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 12, 2017

miq-bot added the fine/yes label Jul 12, 2017

jameswnl deleted the creds2 branch July 13, 2017 14:03

bdunne mentioned this pull request Jul 18, 2017

Backport? (copy) the applicable parts of "New Tower credential types" ManageIQ/manageiq#15598

Merged

bdunne added a commit to bdunne/manageiq that referenced this pull request Jul 19, 2017

Backport? (copy) the applicable parts of "New Tower credential types"

950e16d

ManageIQ/manageiq-providers-ansible_tower#9

simaishi added the bugzilla needed label Aug 4, 2017

simaishi removed the bugzilla needed label Aug 8, 2017

jameswnl mentioned this pull request Aug 10, 2017

[FINE] Porting newly supported Tower credential types to Fine ManageIQ/manageiq#15780

Merged

simaishi added fine/backported and removed fine/yes labels Nov 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Tower credential types #9

New Tower credential types #9

jameswnl commented Jun 27, 2017 •

edited

Loading

jameswnl commented Jun 29, 2017

bronaghs commented Jul 3, 2017 •

edited

Loading

durandom left a comment

durandom Jul 5, 2017

jameswnl Jul 5, 2017

durandom Jul 5, 2017

jameswnl Jul 5, 2017

durandom Jul 5, 2017

jameswnl Jul 5, 2017

jameswnl Jul 5, 2017

durandom Jul 6, 2017

jameswnl Jul 6, 2017

miq-bot commented Jul 11, 2017

miq-bot commented Jul 11, 2017

jameswnl commented Jul 12, 2017

simaishi commented Aug 4, 2017

simaishi commented Nov 28, 2017

		@@ -0,0 +1,49 @@
		module ManageIQ::Providers::AnsibleTower::Shared::AutomationManager::OpenstackCredential
		extend ActiveSupport::Concern

New Tower credential types #9

New Tower credential types #9

Conversation

jameswnl commented Jun 27, 2017 • edited Loading

jameswnl commented Jun 29, 2017

bronaghs commented Jul 3, 2017 • edited Loading

durandom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Jul 11, 2017

miq-bot commented Jul 11, 2017

jameswnl commented Jul 12, 2017

simaishi commented Aug 4, 2017

simaishi commented Nov 28, 2017

jameswnl commented Jun 27, 2017 •

edited

Loading

bronaghs commented Jul 3, 2017 •

edited

Loading