update aws-sdk gem to v3 #488

AlexanderZagaynov · 2018-09-21T10:52:09Z

This is a part of global update aws-sdk gem to v3

Together with:

It should fix #465

Fryguy · 2018-09-21T11:41:27Z

manageiq-providers-amazon.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |s|

  s.files = Dir["{app,config,lib}/**/*"]

-  s.add_dependency("aws-sdk", ["~>2.9.7"])
+  s.add_dependency("aws-sdk", ["~> 3"])


Same comment regarding the gem version, and also remove all of the parens and square brackets (go for consistency with the lines below)

NickLaMuro

@AlexanderZagaynov When the other gem dependency PRs are merged and travis can start running again, I am guessing that #434 is going to start failing, and that PR and #432 are going to have to be removed.

Thinking you probably can wait on that until I am correct in that assumption, but know that it will probably be something you need end up doing in the end.

AlexanderZagaynov · 2018-09-21T14:58:02Z

@NickLaMuro If you mean I should revert / adopt those commits - I'll do.
There is several testing issues anyway, need to change more.

AlexanderZagaynov · 2018-09-26T10:34:04Z

@NickLaMuro that was fixed in aws/aws-sdk-ruby#1760, thanks to @Fryguy :)

https://github.com/aws/aws-sdk-ruby/blob/22f10bed9c6cfb3317b9fc684c124168c5dca71e/gems/aws-sdk-core/lib/seahorse/client/net_http/connection_pool.rb#L262

So, I'm simply remove that patch entirely.

AlexanderZagaynov · 2018-09-26T10:58:40Z

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label hammer/yes

app/models/manageiq/providers/amazon/network_manager/refresh_parser.rb

Fryguy · 2018-10-11T17:39:27Z

Aside from my comment above, this LGTM. @NickLaMuro not sure why you have a request change on this, but what do you think now?

NickLaMuro · 2018-10-11T17:55:50Z

@Fryguy was mostly using that as a reminder that the PRs that I merged to patch aws-sdk have been reverted:

11f987f
1879e5c

Which they have.

But also, that I was suggesting that we wait to confirm the tests failed when the other PRs have been fixed, addressed and merged, since those should be merge-able without requiring other PRs to work. Reason being is that test is in there to confirm we don't have a regression since the fix ( #432 ) really didn't provide a spec of it's own to validate.

Since it seems that amazon_ssa_support also has a manageiq-gems-pending dependency, and merging these separately would basically cause developers to not be able to bundle for a period of time, waiting to do the above might not be possible.

Anyway, I will remove my ❌ since it doesn't seem like there is an easy solution for this.

AlexanderZagaynov · 2018-10-12T09:10:43Z

@NickLaMuro other repos were updated as well.
Check the base issue, it has all the links: #465 and test logs.

NickLaMuro · 2018-10-12T14:49:09Z

@AlexanderZagaynov I am referring to why Travis is currently failing:

Fetching gem metadata from https://rubygems.org/.
Resolving dependencies.......
Bundler could not find compatible versions for gem "aws-sdk":
  In Gemfile:
    manageiq-gems-pending (> 0) was resolved to 0.1.0, which depends on
      aws-sdk (~> 2.9.7)
    manageiq-providers-amazon was resolved to 0.1.0, which depends on
      aws-sdk (~> 3.0)

To get this to pass prior to merging this (in CI), and do what I suggested in the previous comment would probably have some undesirable affects for the rest of the team in the mean time.

Again, I removed my "Request changes" review.

app/models/manageiq/providers/amazon/manager_mixin.rb

djberg96 · 2019-01-25T16:58:25Z

@AlexanderZagaynov What's the word?

AlexanderZagaynov · 2019-01-28T12:09:30Z

@djberg96
in a month :)

…monkey-patch-spec" This reverts commit a08595f, reversing changes made to ce647bc.

…aws-sdk-core-for-proxy-auth-fix" This reverts commit 2b2c87f, reversing changes made to beed01f.

djberg96 · 2019-10-17T12:45:13Z

@AlexanderZagaynov I think you'll need to update the gemspec, too.

AlexanderZagaynov · 2019-10-17T12:52:41Z

@djberg96 you mean this: https://github.com/ManageIQ/manageiq-providers-amazon/pull/488/files#diff-19237fe8b6348694e23d6c2579276b6d ?

djberg96 · 2019-10-17T12:57:36Z

@AlexanderZagaynov Oh, I didn't see it. I guess it's gems-pending that's the culprit.

miq-bot · 2019-10-17T13:36:01Z

Checked commits AlexanderZagaynov/manageiq-providers-amazon@32d337d~...8be7e04 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🍰

AlexanderZagaynov · 2019-10-17T13:38:44Z

All tests are green on my machine with patched versions of all gems mentioned here.

AlexanderZagaynov · 2019-10-18T16:21:45Z

@Fryguy @NickLaMuro @agrare please review

agrare · 2019-10-21T19:12:32Z

Will merge when the cross-repo test is green https://travis-ci.org/agrare/manageiq-cross_repo/builds/600907361

This was referenced Sep 21, 2018

update aws-sdk gem to v3 ManageIQ/manageiq-gems-pending#374

Closed

update aws-sdk gem to v3 ManageIQ/amazon_ssa_support#39

Closed

Fryguy reviewed Sep 21, 2018

View reviewed changes

AlexanderZagaynov force-pushed the aws_sdk_v3 branch 2 times, most recently from 404c1be to ab899ac Compare September 21, 2018 11:44

NickLaMuro suggested changes Sep 21, 2018

View reviewed changes

AlexanderZagaynov force-pushed the aws_sdk_v3 branch from ab899ac to 61eb6d8 Compare September 26, 2018 10:54

miq-bot added gaprindashvili/yes labels Sep 26, 2018

AlexanderZagaynov force-pushed the aws_sdk_v3 branch 3 times, most recently from 519ad9a to e5e5eb2 Compare October 10, 2018 11:04

Fryguy reviewed Oct 11, 2018

View reviewed changes

app/models/manageiq/providers/amazon/network_manager/refresh_parser.rb Outdated Show resolved Hide resolved

NickLaMuro approved these changes Oct 11, 2018

View reviewed changes

Fryguy removed gaprindashvili/yes labels Oct 16, 2018

Fryguy reviewed Oct 16, 2018

View reviewed changes

app/models/manageiq/providers/amazon/manager_mixin.rb Show resolved Hide resolved

miq-bot added the unmergeable label May 23, 2019

Alexander Zagaynov added 3 commits October 11, 2019 13:56

update aws-sdk gem to v3

32d337d

Revert "Merge pull request ManageIQ#434 from NickLaMuro/aws-sdk-auth-…

7cc638c

…monkey-patch-spec" This reverts commit a08595f, reversing changes made to ce647bc.

Revert "Merge pull request ManageIQ#432 from NickLaMuro/monkey-patch-…

1a5f22b

…aws-sdk-core-for-proxy-auth-fix" This reverts commit 2b2c87f, reversing changes made to beed01f.

Alexander Zagaynov added 4 commits October 17, 2019 14:08

fix 'invalid configuration option' issue

79c5d27

fix 'undefined method' error

e44fe91

fix counts assertion errors

ffc67d4

better approach to avoid 'invalid configuration option' error

e5904f0

AlexanderZagaynov force-pushed the aws_sdk_v3 branch from 0ad8451 to e5904f0 Compare October 17, 2019 12:15

This was referenced Oct 17, 2019

require specific aws gems ManageIQ/manageiq#19411

Merged

update aws-sdk gem to v3 ManageIQ/manageiq-gems-pending#449

Merged

AlexanderZagaynov mentioned this pull request Oct 17, 2019

update aws-sdk gem to v3 ManageIQ/amazon_ssa_support#44

Merged

Alexander Zagaynov added 2 commits October 17, 2019 15:16

require specific aws gems

3cfcf0f

fix failing spec

8be7e04

miq-bot removed the unmergeable label Oct 18, 2019

agrare self-assigned this Oct 21, 2019

agrare approved these changes Oct 21, 2019

View reviewed changes

agrare merged commit 9e84410 into ManageIQ:master Oct 21, 2019

agrare added the dependencies label Oct 21, 2019

agrare added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update aws-sdk gem to v3 #488

update aws-sdk gem to v3 #488

AlexanderZagaynov commented Sep 21, 2018 •

edited

Loading

Fryguy Sep 21, 2018

AlexanderZagaynov Sep 21, 2018

NickLaMuro left a comment

AlexanderZagaynov commented Sep 21, 2018

AlexanderZagaynov commented Sep 26, 2018 •

edited

Loading

AlexanderZagaynov commented Sep 26, 2018

Fryguy commented Oct 11, 2018

NickLaMuro commented Oct 11, 2018

AlexanderZagaynov commented Oct 12, 2018 •

edited

Loading

NickLaMuro commented Oct 12, 2018

djberg96 commented Jan 25, 2019

AlexanderZagaynov commented Jan 28, 2019 •

edited

Loading

djberg96 commented Oct 17, 2019

AlexanderZagaynov commented Oct 17, 2019

djberg96 commented Oct 17, 2019

miq-bot commented Oct 17, 2019

AlexanderZagaynov commented Oct 17, 2019

AlexanderZagaynov commented Oct 18, 2019

agrare commented Oct 21, 2019

update aws-sdk gem to v3 #488

update aws-sdk gem to v3 #488

Conversation

AlexanderZagaynov commented Sep 21, 2018 • edited Loading

Fryguy Sep 21, 2018

Choose a reason for hiding this comment

AlexanderZagaynov Sep 21, 2018

Choose a reason for hiding this comment

NickLaMuro left a comment

Choose a reason for hiding this comment

AlexanderZagaynov commented Sep 21, 2018

AlexanderZagaynov commented Sep 26, 2018 • edited Loading

AlexanderZagaynov commented Sep 26, 2018

Fryguy commented Oct 11, 2018

NickLaMuro commented Oct 11, 2018

AlexanderZagaynov commented Oct 12, 2018 • edited Loading

NickLaMuro commented Oct 12, 2018

djberg96 commented Jan 25, 2019

AlexanderZagaynov commented Jan 28, 2019 • edited Loading

djberg96 commented Oct 17, 2019

AlexanderZagaynov commented Oct 17, 2019

djberg96 commented Oct 17, 2019

miq-bot commented Oct 17, 2019

AlexanderZagaynov commented Oct 17, 2019

AlexanderZagaynov commented Oct 18, 2019

agrare commented Oct 21, 2019

AlexanderZagaynov commented Sep 21, 2018 •

edited

Loading

AlexanderZagaynov commented Sep 26, 2018 •

edited

Loading

AlexanderZagaynov commented Oct 12, 2018 •

edited

Loading

AlexanderZagaynov commented Jan 28, 2019 •

edited

Loading