Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aws-sdk gem to v3 #374

Closed

Conversation

AlexanderZagaynov
Copy link
Contributor

@AlexanderZagaynov AlexanderZagaynov commented Sep 21, 2018

@carbonin
Copy link
Member

@NickLaMuro
Copy link
Member

NickLaMuro commented Sep 21, 2018

Oh... I didn't realize this was part of manageiq-gems-pending. Well that makes things easier.

@AlexanderZagaynov can you delete lib/gems/pending/util/extensions/aws-sdk/s3_upload_stream_patch.rb as part of this patch? I think there is one other file in manageiq-providers-amazon that I have also patch that should be in the newest version of the gem (right @Fryguy ? it was your patch I believe).

Update: It was: aws/aws-sdk-ruby#1760 , so see this comment in reference to the changes necessary for manageiq-providers-amazon.

@NickLaMuro
Copy link
Member

@AlexanderZagaynov
Copy link
Contributor Author

@NickLaMuro sure, will do! Thank you for info!

@miq-bot
Copy link
Member

miq-bot commented Oct 12, 2018

Checked commits AlexanderZagaynov/manageiq-gems-pending@7f690e6~...edd0a96 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@miq-bot miq-bot closed this Apr 15, 2019
@miq-bot
Copy link
Member

miq-bot commented Apr 15, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

@AlexanderZagaynov
Copy link
Contributor Author

@Fryguy can this be reopened too?

@AlexanderZagaynov
Copy link
Contributor Author

made a new one: #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade AWS SDK library to version 3
5 participants