Lower the batch sizes to also test multiple batches being processed #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
force-pushed
the
mock_batch_sizes_to_also_test_multiple_batches_being_processed
branch
from
859d6a2 to
75a78fc
Compare
Lower the batch sizes to also test multiple batches being processed
Ladas
force-pushed
the
mock_batch_sizes_to_also_test_multiple_batches_being_processed
branch
from
75a78fc to
371fe86
Compare
|
Some comments on commit Ladas@371fe86 spec/models/manageiq/providers/amazon/aws_refresher_spec_common.rb
|
1 similar comment
|
Some comments on commit Ladas@371fe86 spec/models/manageiq/providers/amazon/aws_refresher_spec_common.rb
|
|
Checked commit Ladas@371fe86 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
reviewed
Aug 24, 2017
| # TODO(lsmola) extract the batch sizes to the settings and stub the settings instead | ||
| # Lower batch sizes to test multiple batches for each collection | ||
| allow_any_instance_of(ManagerRefresh::InventoryCollection).to receive(:batch_size).and_return(4) | ||
| allow_any_instance_of(ManagerRefresh::InventoryCollection).to receive(:batch_size_pure_sql).and_return(4) |
There was a problem hiding this comment.
I dislike allow_any_instance_of this is a good reason why the batch size should be configurable
agrare
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Lower the batch sizes to also test multiple batches being processed