Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all refresh strategies in aws #282

Merged
merged 6 commits into from
Aug 14, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Aug 11, 2017

Depends on:

Test all refresh strategies in aws using the options from Settings

AWS shared options based on Settings
Ladas added 5 commits August 11, 2017 15:15
Expose all combinations of tested settings
Test all the refresh settings by the AWS stubbed refreshers
VCR specs need to test all refresh settings
Keep check_changed default and settable by Settings
Use shared_options in TargetCollection Persister
@agrare agrare closed this Aug 11, 2017
@agrare agrare reopened this Aug 11, 2017
@Ladas Ladas force-pushed the test_all_refresh_strategies_in_aws branch from 0761d05 to f1a67bd Compare August 11, 2017 15:30
@miq-bot
Copy link
Member

miq-bot commented Aug 11, 2017

Checked commits Ladas/manageiq-providers-amazon@f9fb80a~...f1a67bd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
11 files checked, 0 offenses detected
Everything looks fine. 🏆

@Ladas Ladas closed this Aug 14, 2017
@Ladas Ladas reopened this Aug 14, 2017
@Ladas Ladas closed this Aug 14, 2017
@Ladas Ladas reopened this Aug 14, 2017
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit 94cfa25 into ManageIQ:master Aug 14, 2017
@agrare agrare added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants