-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test all refresh strategies in aws #282
Merged
agrare
merged 6 commits into
ManageIQ:master
from
Ladas:test_all_refresh_strategies_in_aws
Aug 14, 2017
Merged
Test all refresh strategies in aws #282
agrare
merged 6 commits into
ManageIQ:master
from
Ladas:test_all_refresh_strategies_in_aws
Aug 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS shared options based on Settings
Expose all combinations of tested settings
Test all the refresh settings by the AWS stubbed refreshers
VCR specs need to test all refresh settings
Keep check_changed default and settable by Settings
Use shared_options in TargetCollection Persister
2 tasks
Ladas
force-pushed
the
test_all_refresh_strategies_in_aws
branch
from
August 11, 2017 15:30
0761d05
to
f1a67bd
Compare
Checked commits Ladas/manageiq-providers-amazon@f9fb80a~...f1a67bd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
approved these changes
Aug 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Test all refresh strategies in aws using the options from Settings