Add a flag to gate worker resource constraints #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The orchestrator code in the app will use this to determine if we should set worker deployment resource constraints when creating new workers. Like the rest of the resource constraints, these are off by default.
|
Checked commit carbonin@b9941df with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint **
|
jrafanie
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
I'm not familiar with this but it looks like it's setting the value correctly from ManageIQ/manageiq#20193
|
@bdunne can you take a look at this one? |
simaishi
pushed a commit
that referenced
this pull request
Jul 7, 2020
Add a flag to gate worker resource constraints (cherry picked from commit 2b8519e)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orchestrator code in the app will use this to determine if we
should set worker deployment resource constraints when creating
new workers.
Like the rest of the resource constraints, these are off by default.
Needed for ManageIQ/manageiq#20163
Merge with ManageIQ/manageiq#20193