-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ENOENT error from backup_pg_compress #332
Merged
bdunne
merged 1 commit into
ManageIQ:master
from
agrare:fix_pg_backup_error_no_such_file_or_dir
Jan 26, 2018
Merged
Fix ENOENT error from backup_pg_compress #332
bdunne
merged 1 commit into
ManageIQ:master
from
agrare:fix_pg_backup_error_no_such_file_or_dir
Jan 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dir.mktmpdir fails if the base directory doesn't exist with ENOENT so first make sure that the base path exists. https://travis-ci.org/ManageIQ/manageiq/jobs/333519975#L1334-L1350
cc @kbrock |
Checked commit agrare@b391b10 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Not sure if there's a better place to initialize this directory but this fixes the test |
bdunne
approved these changes
Jan 26, 2018
Based on changes in #331 |
Thanks @bdunne 👍 |
Thanks for catching this @agrare |
simaishi
pushed a commit
that referenced
this pull request
Jan 26, 2018
…or_dir Fix ENOENT error from backup_pg_compress (cherry picked from commit cd8fcb9) https://bugzilla.redhat.com/show_bug.cgi?id=1539060
Gaprindashvili backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dir.mktmpdir fails if the base directory doesn't exist with ENOENT so
first make sure that the base path exists.
https://travis-ci.org/ManageIQ/manageiq/jobs/333519975#L1334-L1350