Create an empty directory for pg_basebackup #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the
--pgdata
option.Previously we were trying to use the directory of the path given
for the backup file name. This was failing because there is no
guarentee that the directory given is empty.
This commit creates a temp directory in the parent directory of
the given file. This ensures that we are writing the backup on the
same volume that the user intends the backup to be stored on so we are
much more likely to have space to write.
https://bugzilla.redhat.com/show_bug.cgi?id=1538584