Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify rhel7 as the scap security guide platform #275

Merged
merged 3 commits into from
Oct 3, 2017
Merged

Specify rhel7 as the scap security guide platform #275

merged 3 commits into from
Oct 3, 2017

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Sep 26, 2017 •
edited
Loading

@carbonin
Copy link
Member Author

carbonin commented Oct 2, 2017

This also will need a linux_admin version bump to pick up the referenced PRs.

Fryguy
Fryguy approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a linux_admin gem release

@carbonin carbonin closed this Oct 3, 2017
@carbonin carbonin reopened this Oct 3, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2017

Checked commits carbonin/manageiq-gems-pending@15da358~...046c081 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@carbonin
Copy link
Member Author

carbonin commented Oct 3, 2017

🎉 Ping @bdunne This will bring in the new linux_admin version

@bdunne bdunne merged commit 2f0d09f into ManageIQ:master Oct 3, 2017
@bdunne bdunne added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 3, 2017
simaishi pushed a commit that referenced this pull request Oct 3, 2017
@bdunne @simaishi
Merge pull request #275 from carbonin/specify_platform_for_scap
513e4d0 
Specify rhel7 as the scap security guide platform
(cherry picked from commit 2f0d09f)

https://bugzilla.redhat.com/show_bug.cgi?id=1498230
@simaishi
Copy link
Contributor

simaishi commented Oct 3, 2017

Fine backport details:

$ git log -1
commit 513e4d07dfcf0aec782613905b8da872689c4ae5
Author: Brandon Dunne <[email protected]>
Date:   Tue Oct 3 13:34:22 2017 -0400

    Merge pull request #275 from carbonin/specify_platform_for_scap
    
    Specify rhel7 as the scap security guide platform
    (cherry picked from commit 2f0d09ff0147bf1bd230e87ac799e300c3e30067)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1498230

@simaishi
Copy link
Contributor

simaishi commented Oct 4, 2017

Euwe backport details:

$ git log -1
commit e303bdb8345b8c47f87651f359bcee4a6ab5468f
Author: Brandon Dunne <[email protected]>
Date:   Tue Oct 3 13:34:22 2017 -0400

    Merge pull request #275 from carbonin/specify_platform_for_scap
    
    Specify rhel7 as the scap security guide platform
    (cherry picked from commit 2f0d09ff0147bf1bd230e87ac799e300c3e30067)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1498232

@carbonin carbonin deleted the specify_platform_for_scap branch October 13, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@Fryguy Fryguy Fryguy approved these changes

Assignees

@bdunne bdunne

Labels
blocker bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carbonin @miq-bot @simaishi @Fryguy @bdunne