Add platform attribute to Scap class #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Sep 26, 2017
| end | ||
|
|
||
| def tempdir | ||
| @tempdir ||= Pathname.new(Dir.tmpdir) | ||
| end | ||
|
|
||
| def xccdf_file | ||
| @xccdf_file ||= self.class.xccdf_file | ||
| @xccdf_file ||= self.class.xccdf_file(platform) |
There was a problem hiding this comment.
If the platform changes via the accessor, then this cache should be cleared, right? (same with oval_file)
There was a problem hiding this comment.
Alternately, use attr_reader instead, then enforce that callers must set the platform on initialize.
There was a problem hiding this comment.
I'm for the attr_reader approach, I don't see someone reusing this object for different platforms so I think it makes sense to set it on initialization.
Newer versions of scap-security-guide (> 0.1.32) add new xccdf files which match our glob pattern, but do not contain the remediations for the rules we want to run. If we edit one of these files rather than the one for our target platform, the rules will not be remediated properly. Specifying the platform allows us to find the file we need. https://bugzilla.redhat.com/show_bug.cgi?id=1493193
carbonin
force-pushed
the
add_platform_attr_to_scap
branch
from
a7534e2 to
8f90905
Compare
|
Checked commit carbonin@8f90905 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 lib/linux_admin/scap.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of scap-security-guide (> 0.1.32) add new xccdf files which match our glob pattern, but do not contain the remediations for the rules we want to run.
If we edit one of these files rather than the one for our target platform, the rules will not be remediated properly.
Specifying the platform allows us to find the file we need.
https://bugzilla.redhat.com/show_bug.cgi?id=1493193