Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring update_serviceprovision_status method #19

Merged
merged 4 commits into from
Jan 27, 2017
Merged

Refactoring update_serviceprovision_status method #19

merged 4 commits into from
Jan 27, 2017

Conversation

pkomanek
Copy link
Contributor

@pkomanek pkomanek commented Jan 13, 2017 •
edited
Loading

Purpose or Intent

Refactoring the update_serviceprovision_status methods and specs. This PR is based on the issue bellow.

Links [Optional]

#8

@pkomanek
Copy link
Contributor Author

@miq-bot add_labels automate, enhancement, refactoring, wip

@miq-bot
Copy link
Member

miq-bot commented Jan 13, 2017

@pkomanek Cannot apply the following labels because they are not recognized: automate, refactoring, wip

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2017

Checked commits pkomanek/manageiq-content@573e16a~...236a9df with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
6 files checked, 1 offense detected

content/automate/ManageIQ/Service/Provisioning/StateMachines/ServiceProvision_Template.class/methods/update_serviceprovision_status.rb

@pkomanek pkomanek changed the title [WIP] Refactoring update_serviceprovision_status method Refactoring update_serviceprovision_status method Jan 19, 2017
mkanoor
mkanoor reviewed Jan 26, 2017
View reviewed changes
.../StateMachines/ServiceProvision_Template.class/__methods__/update_serviceprovision_status.rb
module Service
module Provisioning
module StateMachines
module ServiceProvision_Template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkomanek can this be module ServiceProvisionTemplate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkomanek I am not sure if thats because of an internal naming issue. We might have to leave it as ServiceProvision_Template. @tinaafitz can you comment on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkanoor @pkomanek It is an internal naming issue, so we have to leave the name as ServiceProvision_Template.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ManageIQ/manageiq/blob/master/app/models/service_template.rb#L262

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ManageIQ/manageiq/blob/master/app/models/service_template_provision_task.rb#L123

@mkanoor mkanoor mentioned this pull request Jan 26, 2017
Merged
@billfitzgerald0120 billfitzgerald0120 mentioned this pull request Jan 26, 2017
Closed
@mkanoor mkanoor merged commit 6d2f13a into ManageIQ:master Jan 27, 2017
@pkomanek pkomanek deleted the refactoring_update_serviceprovision_status branch January 31, 2017 11:55
@mkanoor mkanoor added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

@tinaafitz tinaafitz tinaafitz left review comments

Assignees

@mkanoor mkanoor

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkomanek @miq-bot @tinaafitz @mkanoor