Automate - Notification for Ansible and Cloud provisioning errors. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billfitzgerald0120
force-pushed
the
cnotify_ansible
branch
from
cdcc6c0 to
d777eaf
Compare
|
@tinaafitz |
|
@billfitzgerald0120 Looks good. |
|
@billfitzgerald0120 @tinaafitz Can this PR wait till this refactored one gets merged. |
|
@mkanoor |
|
This pull request is not mergeable. Please rebase and repush. |
billfitzgerald0120
force-pushed
the
cnotify_ansible
branch
from
d777eaf to
f011aa4
Compare
|
@tinaafitz |
billfitzgerald0120
force-pushed
the
cnotify_ansible
branch
from
f011aa4 to
9754749
Compare
|
@tinaafitz |
|
@billfitzgerald0120 Looks good. |
|
@miq-bot add-label enhancement |
billfitzgerald0120
force-pushed
the
cnotify_ansible
branch
from
9754749 to
f424719
Compare
|
Checked commits billfitzgerald0120/manageiq-content@ae2c062~...f424719 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@mkanoor Please review. |
|
@mkanoor Can this be merged? Please label |
mkanoor
approved these changes
Mar 30, 2017
simaishi
pushed a commit
that referenced
this pull request
Mar 30, 2017
Automate - Notification for Ansible and Cloud provisioning errors. (cherry picked from commit ee6b46b)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends a notification with an error occurs.
Modified update_serviceprovision_status methods in
Cloud/Orchestration/Provisioning/StateMachines/Provision/ and
ConfigurationManagement/AnsibleTower/Service/Provisioning/StateMachines/Provision
Methods class.
Updated existing spec to test for notification in case of error.