convert_value_based_on_datatype won't take "Integer" #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
|
@miq-bot add_reviewer @tinaafitz |
|
@miq-bot add_label hammer/yes |
gmcculloug
reviewed
Oct 24, 2018
| @@ -559,7 +559,7 @@ def self.convert_value_based_on_datatype(value, datatype) | |||
| return false if datatype == 'FalseClass' | |||
| return Time.parse(value) if datatype == 'time' || datatype == 'Time' | |||
| return value.to_sym if datatype == 'symbol' || datatype == 'Symbol' | |||
| return value.to_i if datatype == 'integer' || datatype == 'Fixnum' | |||
| return value.to_i if datatype == 'integer' || datatype == 'Fixnum' || datatype == 'Integer' | |||
There was a problem hiding this comment.
Maybe: datatype.casecmp?('integer')
d-m-u
force-pushed
the
integer_or_Integer_in_object_convert_value_based_on_datatype
branch
from
1f0fb97 to
6f970b0
Compare
gmcculloug
reviewed
Oct 24, 2018
| return value.gsub(/[\[\]]/, '').strip.split(/\s*,\s*/) if datatype == 'array' && value.class == String | ||
| return Time.parse(value) if datatype.casecmp?('time') | ||
| return value.to_sym if datatype.casecmp?('symbol') | ||
| return value.to_i if datatype.casecmp?('integer') || datatype == 'Fixnum' |
There was a problem hiding this comment.
The lower-case 'integer' type comes from the Automate class schema which is why we initially had that value and Fixnum. Ruby 2.4 replaced Fixnum with Integer which causes the issue.
Since we still support Ruby 2.3 we will need to retain the Fixnum check here for a bit longer.
gmcculloug
approved these changes
Oct 24, 2018
d-m-u
force-pushed
the
integer_or_Integer_in_object_convert_value_based_on_datatype
branch
from
1f1d4a7 to
d6ad1a1
Compare
|
@gmcculloug can you please take another look? |
d-m-u
force-pushed
the
integer_or_Integer_in_object_convert_value_based_on_datatype
branch
5 times, most recently
from
fd16f2b to
2f1338c
Compare
gmcculloug
reviewed
Oct 24, 2018
d-m-u
force-pushed
the
integer_or_Integer_in_object_convert_value_based_on_datatype
branch
2 times, most recently
from
0b919fc to
79acbfc
Compare
gmcculloug
reviewed
Oct 25, 2018
spec/miq_ae_object_spec.rb
Outdated
| let(:datatype2) { "Fixnum" } | ||
|
|
||
| it "returns value to_i" do | ||
| expect(described_class.convert_value_based_on_datatype(value, datatype)).to eq(45) |
There was a problem hiding this comment.
Could we just loop over the different datatypes in one test? There's not a big difference between the first test returns value to_i and the other two returns value to_i so maybe we just combine them.
d-m-u
force-pushed
the
integer_or_Integer_in_object_convert_value_based_on_datatype
branch
from
79acbfc to
1aaf5fc
Compare
|
Checked commit d-m-u@1aaf5fc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
deleted the
integer_or_Integer_in_object_convert_value_based_on_datatype
branch
simaishi
pushed a commit
that referenced
this pull request
Oct 25, 2018
…rt_value_based_on_datatype convert_value_based_on_datatype won't take "Integer" (cherry picked from commit 67488e4) https://bugzilla.redhat.com/show_bug.cgi?id=1628224
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR I need to fix https://bugzilla.redhat.com/show_bug.cgi?id=1628224. Custom Buttons on multiple objects aren't being run because the engine won't take "Integer" ... which I think it should. This hackiness seems to be the convention for Time and Symbol.
related
already merged
ManageIQ/manageiq#18056