Merge pull request #258 from d-m-u/integer_or_Integer_in_object_conve…

…rt_value_based_on_datatype

convert_value_based_on_datatype won't take "Integer"

(cherry picked from commit 67488e4)

https://bugzilla.redhat.com/show_bug.cgi?id=1628224

lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb

@@ -559,7 +559,7 @@ def self.convert_value_based_on_datatype(value, datatype)
       return false                                           if datatype == 'FalseClass'
       return Time.parse(value)                               if datatype == 'time' || datatype == 'Time'
       return value.to_sym                                    if datatype == 'symbol' || datatype == 'Symbol'
-      return value.to_i                                      if datatype == 'integer' || datatype == 'Fixnum'
+      return value.to_i                                      if %w(integer Integer Fixnum).include?(datatype)
       return value.to_f                                      if datatype == 'float' || datatype == 'Float'
       return value.gsub(/[\[\]]/, '').strip.split(/\s*,\s*/)  if datatype == 'array' && value.class == String
       return decrypt_password(value) if datatype == 'password'

spec/miq_ae_object_spec.rb

@@ -316,4 +316,10 @@ def value_match(value, xml_value)
       end.to raise_exception(MiqPassword::MiqPasswordError)
     end
   end
+
+  context "integer" do
+    it "returns value to_i" do
+      %w(Integer integer Fixnum).each { |type| expect(described_class.convert_value_based_on_datatype("45", type)).to eq(45) }
+    end
+  end
 end