Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New service model for v2v request and task #155

Merged
merged 1 commit into from
Feb 20, 2018
Merged

New service model for v2v request and task #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...tion_engine/service_models/miq_ae_service_service_template_transformation_plan_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module MiqAeMethodService
class MiqAeServiceServiceTemplateTransformationPlanRequest < MiqAeServiceServiceTemplateProvisionRequest
expose :source_vms, :association => true
expose :validate_vm, :association => true
expose :approve_vm, :association => true
end
end
11 changes: 11 additions & 0 deletions ...omation_engine/service_models/miq_ae_service_service_template_transformation_plan_task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
module MiqAeMethodService
class MiqAeServiceServiceTemplateTransformationPlanTask < MiqAeServiceServiceTemplateProvisionTask
expose :update_transformation_progress

def transformation_destination(source_obj)
ar_method do
wrap_results(@object.transformation_destination(source_obj.object_class.find(source_obj.id)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Should this use find! instead of find

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that find raises error if is not found. There is no find! in AR model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Can we push this into the backend model?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is here because you don't want to do source_obj.object_class outside of automate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise the backend needs to covert a service model to AR model.

end
end
end
end