Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New service model for v2v request and task #155

Merged
merged 1 commit into from
Feb 20, 2018
Merged

New service model for v2v request and task #155

merged 1 commit into from
Feb 20, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Feb 6, 2018

@bzwei
Copy link
Contributor Author

bzwei commented Feb 6, 2018

@miq-bot add_label v2v

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

@bzwei Cannot apply the following label because they are not recognized: v2v

@miq-bot miq-bot added the wip label Feb 6, 2018
@bzwei
Copy link
Contributor Author

bzwei commented Feb 6, 2018

cc @fdupont-redhat @lfu
@miq-bot assign @gmcculloug

@bzwei bzwei force-pushed the service_model_v2v branch from 06971ac to 0c19265 Compare February 7, 2018 16:35
@bzwei bzwei mentioned this pull request Feb 7, 2018
Merged
@bzwei bzwei force-pushed the service_model_v2v branch from 0c19265 to 2e1b67d Compare February 7, 2018 22:22
@bzwei bzwei force-pushed the service_model_v2v branch from 2e1b67d to cccc456 Compare February 13, 2018 18:47
@bzwei
Copy link
Contributor Author

bzwei commented Feb 13, 2018

@miq-bot add_label enhancement

mkanoor
mkanoor reviewed Feb 13, 2018
View reviewed changes
...automation_engine/service_models/miq_ae_service_service_template_transformation_plan_task.rb

def transformation_destination(source_obj)
ar_method do
wrap_results(@object.transformation_destination(source_obj.object_class.find(source_obj.id)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Should this use find! instead of find

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that find raises error if is not found. There is no find! in AR model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Can we push this into the backend model?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is here because you don't want to do source_obj.object_class outside of automate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise the backend needs to covert a service model to AR model.

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2018

Checked commit bzwei@cccc456 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@gmcculloug
Copy link
Member

@bzwei un-wip?

@bzwei bzwei changed the title [wip] New service model for v2v request and task New service model for v2v request and task Feb 19, 2018
@bzwei
Copy link
Contributor Author

bzwei commented Feb 19, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Feb 19, 2018
@gmcculloug gmcculloug merged commit 9fd66be into ManageIQ:master Feb 20, 2018
@gmcculloug gmcculloug added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 20, 2018
paulslaby pushed a commit to paulslaby/manageiq-automation_engine that referenced this pull request Feb 22, 2018
@gmcculloug @paulslaby
Merge pull request ManageIQ#155 from bzwei/service_model_v2v
6d35545 
New service model for v2v request and task
simaishi pushed a commit that referenced this pull request May 29, 2018
@gmcculloug @simaishi
Merge pull request #155 from bzwei/service_model_v2v
2ba13c3 
New service model for v2v request and task
(cherry picked from commit 9fd66be)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2ba13c349abaf7160b8a66d7f4372414558a5401
Author: Greg McCullough <[email protected]>
Date:   Tue Feb 20 09:34:55 2018 -0500

    Merge pull request #155 from bzwei/service_model_v2v
    
    New service model for v2v request and task
    (cherry picked from commit 9fd66be2def35cd1b23d1bba2eac517aac83f37f)

@Fryguy Fryguy added v2v and removed transformation labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor left review comments

@gmcculloug gmcculloug gmcculloug left review comments

Assignees

@gmcculloug gmcculloug

Labels
enhancement gaprindashvili/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzwei @miq-bot @gmcculloug @simaishi @mkanoor @Fryguy