Improved request_spec by removing direct filtering by Classification#parent_id #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label bug |
|
/cc @gtanzillo @kbrock |
gtanzillo
reviewed
Jun 14, 2019
spec/requests/requests_spec.rb
Outdated
| @@ -258,7 +258,7 @@ | |||
|
|
|||
| FactoryBot.create(:classification_department_with_tags) | |||
|
|
|||
| t = Classification.where(:description => 'Department', :parent_id => 0).includes(:tag).first | |||
| t = Classification.where(:description => 'Department', :parent_id => nil).includes(:tag).first | |||
There was a problem hiding this comment.
This looks a bit strange because the category should have :parent_id => 0 in Classifications. Is it possible that the factory can be fixed to ensure that the category is created that way instead of this change?
kbrock
requested changes
Jun 15, 2019
yrudman
force-pushed
the
fixed-rspec-for-request-with-classification-parent-nil
branch
from
d82fe80 to
68f14b0
Compare
…- get rid of direct filtering by Classification#parent_id
yrudman
force-pushed
the
fixed-rspec-for-request-with-classification-parent-nil
branch
from
68f14b0 to
95bd358
Compare
|
Checked commit yrudman@95bd358 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
yrudman
changed the title
yrudman
deleted the
fixed-rspec-for-request-with-classification-parent-nil
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get rid of direct filtering by 'Classification#parent_id' in rspec
Improvement suggested by @kbrock to #610
@miq-bot add-label test