Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX CI: Parent_id should equals to nil - it is default value in request_specs #610

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

lpichler
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Jun 14, 2019

Checked commit lpichler@9a6b74e with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@bdunne bdunne merged commit 50c50d5 into ManageIQ:master Jun 14, 2019
@bdunne bdunne added this to the Sprint 114 Ending Jun 24, 2019 milestone Jun 14, 2019
@bdunne bdunne assigned bdunne and unassigned jrafanie Jun 14, 2019
@kbrock
Copy link
Member

kbrock commented Jun 15, 2019

after note:

In the future, lets use is_category for stuff like this:

Classification.is_category.where(:description => 'Department').includes(:tag).first

I'm surprised there were any :parent_id => *** left anywhere in our code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants