Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the regions if they're supported with OPTIONS /api/providers #581

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

skateman
Copy link
Member

Requested by @Hyperkid123 in the issue below as a followup on #579, he needs the list of supported regions for providers that support it.

$ curl -u admin:smartvm -XOPTIONS "http://localhost:3000/api/providers"
    // ...
    "supported_providers": [
      // ...
      {
        "title": "Amazon EC2",
        "type": "ManageIQ::Providers::Amazon::CloudManager",
        "kind": "cloud",
        "regions": [
          {
            "name": "ap-south-1",
            "description": "Asia Pacific (Mumbai)"
          },
      // ...

Fixes #580
@miq-bot add_label changelog/yes, hammer/no, enhancement
@miq-bot assign @abellotti

I am a little worried about writing a spec for this, because I'm not 100% sure that we'd have a cloud provider neither that a cloud provider always has regions supported.

@Hyperkid123
Copy link
Contributor

Hyperkid123 commented Apr 30, 2019

@skateman brilliant. Thank you!

@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2019

Checked commit skateman@01ca75e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@abellotti abellotti added this to the Sprint 111 Ending May 13, 2019 milestone Apr 30, 2019
@abellotti abellotti self-requested a review April 30, 2019 17:03
@abellotti
Copy link
Member

Thanks @skateman for the API enhancement. LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint for provider regions.
4 participants