-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a list of supported providers in OPTIONS /api/providers
#579
Conversation
46cea69
to
16845cd
Compare
Checked commit skateman@16845cd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Getting closer and closer to pure pluggability!
Love it @skateman ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
looks good, also adding the new element so not breaking compatibility, so 👍 from me. |
🎉 |
@miq-bot add_label changelog/yes |
@Hyperkid123 is working on the new API-driven forms for adding a provider and for that he needs a way to ask for the list of supported providers with their names and classes. Since ManageIQ/manageiq#18568 we can ask for the list of the provider classes that are available for adding via the UI.
Originally I wanted to group these fields by the
kind
of the provider, but IMO this can be done on the client much easier. Maybe thekind
andtype
keys should be changed to something else, I wasn't sure about theclass
as it might be a reserved word in other worlds.@miq-bot add_reviewer @abellotti
@miq-bot add_reviewer @djberg96
cc @Hyperkid123, @agrare, @martinpovolny