This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1LP][RFR] Add test_appliance_replicate_remote_down #9964
[1LP][RFR] Add test_appliance_replicate_remote_down #9964
Changes from all commits
d71ad6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a browser refresh here? If it is necessary, can you just do
global_appliance.browser.refresh()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using a browser refresh because the Replication tab is already displayed from the first call to get_replication_status(). After the firewall rule is added, we want to verify that the Replication tab re-displays successfully, but the second call to get_replication_status() doesn't do any navigation/refresh since the view is already being displayed.
global_appliance.browser is a ViaUI instance and doesn't have the refresh() method, whereas global_appliance.browser.widgetastic is the MiqBrowser instance that provides access to refresh() and other Selenium actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for the explanation. One possible enhancement could be to have a
force
arg or kwarg in thatget_replication_status
so you can refresh the page via that method. I'd consider this optional however.