Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Add test_appliance_replicate_remote_down #9964

Merged
merged 1 commit into from
Mar 13, 2020
Merged

[1LP][RFR] Add test_appliance_replicate_remote_down #9964

merged 1 commit into from
Mar 13, 2020

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Mar 3, 2020

Add test_appliance_replicate_remote_down for BZ coverage of:

Bug 1796681 - Replication tab presenting 502 proxy error when remote site is down
https://bugzilla.redhat.com/show_bug.cgi?id=1796681

and remove outdated manual test test_subscription_region_unavailable.

{{ pytest: --long-running -k test_appliance_replicate_remote_down cfme/tests/distributed/test_appliance_replication.py -v }}

@tpapaioa tpapaioa changed the title [WIPTEST] Add test_appliance_replicate_remote_down [RFR] Add test_appliance_replicate_remote_down Mar 4, 2020
@dajoRH dajoRH removed the WIP-testing label Mar 4, 2020
@dajoRH dajoRH changed the title [RFR] Add test_appliance_replicate_remote_down [WIP] Add test_appliance_replicate_remote_down Mar 5, 2020
@tpapaioa tpapaioa changed the title [WIP] Add test_appliance_replicate_remote_down [WIPTEST] Add test_appliance_replicate_remote_down Mar 6, 2020
@tpapaioa tpapaioa changed the title [WIPTEST] Add test_appliance_replicate_remote_down [RFR] Add test_appliance_replicate_remote_down Mar 11, 2020
@john-dupuy john-dupuy added the test-automation To be applied on PR's which are automating existing manual cases label Mar 12, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions, looking great!

" -j DROP")
assert result.success, "Could not create firewall rule on global appliance."

global_appliance.browser.widgetastic.refresh()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a browser refresh here? If it is necessary, can you just do global_appliance.browser.refresh()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using a browser refresh because the Replication tab is already displayed from the first call to get_replication_status(). After the firewall rule is added, we want to verify that the Replication tab re-displays successfully, but the second call to get_replication_status() doesn't do any navigation/refresh since the view is already being displayed.

global_appliance.browser is a ViaUI instance and doesn't have the refresh() method, whereas global_appliance.browser.widgetastic is the MiqBrowser instance that provides access to refresh() and other Selenium actions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for the explanation. One possible enhancement could be to have a force arg or kwarg in that get_replication_status so you can refresh the page via that method. I'd consider this optional however.

@dajoRH dajoRH changed the title [RFR] Add test_appliance_replicate_remote_down [WIP] Add test_appliance_replicate_remote_down Mar 12, 2020
@tpapaioa tpapaioa changed the title [WIP] Add test_appliance_replicate_remote_down [WIPTEST] Add test_appliance_replicate_remote_down Mar 12, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Mar 12, 2020
@tpapaioa tpapaioa changed the title [WIPTEST] Add test_appliance_replicate_remote_down [RFR] Add test_appliance_replicate_remote_down Mar 12, 2020
@john-dupuy john-dupuy changed the title [RFR] Add test_appliance_replicate_remote_down [1LP][RFR] Add test_appliance_replicate_remote_down Mar 12, 2020
@dajoRH dajoRH changed the title [1LP][RFR] Add test_appliance_replicate_remote_down [1LP][WIP] Add test_appliance_replicate_remote_down Mar 13, 2020
@dajoRH dajoRH added the WIP label Mar 13, 2020
@tpapaioa tpapaioa changed the title [1LP][WIP] Add test_appliance_replicate_remote_down [1LP][WIPTEST] Add test_appliance_replicate_remote_down Mar 13, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Mar 13, 2020
@tpapaioa tpapaioa changed the title [1LP][WIPTEST] Add test_appliance_replicate_remote_down [1LP][RFR] Add test_appliance_replicate_remote_down Mar 13, 2020
@mshriver mshriver self-assigned this Mar 13, 2020
@mshriver mshriver merged commit bc0b69e into ManageIQ:master Mar 13, 2020
@tpapaioa tpapaioa deleted the test_remote_appliance_down branch March 15, 2020 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants