-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pagination for cell list on transaction page #222
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Two messages to @Sven-TBD
|
|
Could you post an image to illustrate how it should be? Cuz I haven't used kindle for a while.
My question is a bit confusing, I was trying to confirm if the count of the input list should be the same of the output list. Say, when I set the count of the input list to 20, will the output list be changed from 10 to 20 simultaneously or still be 10? |
It's better if both of them change simultaneously. because the main reason of adjusting the length of these lists is that users want a better view experience, so it's unneccessary to adjust asynchronously. but in current design, it is separative , so I'm doing the new prototype, I think the new one will update soon. |
It may be over-considered to update the PRD because it's just a detail I want to confirm. Now I know that these two |
The page size selector will be hidden when the width in scope of (750px, 900px) and (0, 600px) because its layout will be reconsidered in terms of design
…ickbase/ckb-explorer-frontend into add-pagination-for-cell-list
a92607b
to
cef2427
Compare
The
The requested range overflows in case 1, say there are 14 items, set page size 15, and visit the page 2, there should be no data displayed because the index on page 2 starts from 15. There are generally 2 solutions:
For case 2, I would suggest opening a new issue to optimize the footer because fixing the dropdown doesn't help much, the footer will still cover others when it overlaps with other elements. |
ok,I will create a new issue to track this issue.
What about this part? @Sven-TBD |
This problem will be fixed in #533. |
Overflow of page number should be fixed by e57e75d, it redirects to the last page when |
2024-01-24.17.35.50.movSimilar problems arise when using cross-reference between |
I think it's a problem caused by BTW I found the |
Please check if it's acceptable that one list is empty when the last page of the other list is visited. @Sven-TBD |
If the size is adjusted, the list refreshes and everything is positioned on the first page. @Keith-CY |
1317b1d
to
500453d
Compare
Please have a review @Daryl-L @PainterPuppets @WhiteMinds |
This PR enables cell pagination on the Transaction page
Ref: Magickbase/ckb-explorer-public-issues#484
Preview: https://ckb-explorer-frontend-in-magickbase-repo-git-10bf71-magickbase.vercel.app/transaction/0xc0d63615267e6a30d871b6d35551619641ba699138c1337470f4cdb7f8b91f1b?page_of_inputs=1
Note that
page size selector
is hidden when the width is in the scope of [0, 600px] and [750px, 900px] because the layout should be adjusted in the future.