Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase pagination for inputs and outputs on the transaction details page #484

Closed
Sven-TBD opened this issue Nov 13, 2023 · 7 comments
Closed

Increase pagination for inputs and outputs on the transaction details page #484

Sven-TBD opened this issue Nov 13, 2023 · 7 comments
Assignees
@zhangyouxin @FrederLu
Labels
enhancement New feature or request

Comments

@Sven-TBD
Copy link
Contributor

Sven-TBD commented Nov 13, 2023 •
edited
Loading

EN
The backend interface has been optimized for pagination mode.
nervosnetwork/ckb-explorer#1496
A pagination component also needs to be added to the details list on the "Transaction Details Page". When the number of Inputs/Outputs in a transaction exceeds the number displayed per page, a pagination bar should be displayed.

zh_CN
后端接口优化为分页模式
nervosnetwork/ckb-explorer#1496

因此，
对应《交易详情页》的详情列表处也需要加上分页组件，在交易内Inputs/Outputs 数量超过每页面展示数量时，展示分页栏。

image

@Kirl70
@Sven-TBD Sven-TBD converted this from a draft issue Nov 13, 2023
@Sven-TBD Sven-TBD self-assigned this Nov 13, 2023
@Sven-TBD Sven-TBD moved this from 🆕 New to 📌Planning in CKB Explorer Nov 20, 2023
@Kirl70
Copy link

Kirl70 commented Nov 23, 2023 •
edited
Loading

Design Draft:
https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=6102%3A26855&mode=design&t=PVDXXqHnNNJ6Khfy-1
image

@Sven-TBD Sven-TBD moved this from 📌Planning to 🏗 In Progress in CKB Explorer Nov 29, 2023
@Sven-TBD
Copy link
Contributor Author

Latest UI updated here

Please note that this alarm will only show when the number of transactions for the current address exceeds the default limit.

Image

@Sven-TBD Sven-TBD added the enhancement New feature or request label Nov 29, 2023
@Sven-TBD Sven-TBD mentioned this issue Nov 29, 2023
Closed
@WhiteMinds
Copy link

I think it would be best to allow users to control the pagination quantity per page, such as 5 / 25 / 100.

If single-page unlimited quantity is not provided, it may also require a filtering feature. Otherwise, it can be challenging to find specific inputs/outputs when there are a large number of pages.

@zhangyouxin zhangyouxin mentioned this issue Dec 12, 2023
Closed
@zhangyouxin
Copy link

Magickbase/ckb-explorer-frontend#177

@zhangyouxin zhangyouxin moved this from 🏗 In Progress to 🔎 Code Review in CKB Explorer Dec 18, 2023
@Sven-TBD Sven-TBD moved this from 🔎 Code Review to 👀 Testing in CKB Explorer Dec 25, 2023
@zhangyouxin zhangyouxin mentioned this issue Dec 29, 2023
Closed
@Keith-CY Keith-CY mentioned this issue Jan 19, 2024
Merged
@Keith-CY
Copy link
Member

Should be updated by Magickbase/ckb-explorer-frontend#222

@Kirl70
Copy link

Kirl70 commented Jan 22, 2024

Adjust according to PRD:
https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=6102%3A26855&mode=design&t=p7mSfysOos1fmA3B-1
image

@github-actions github-actions bot mentioned this issue Jan 25, 2024
Merged
@FrederLu
Copy link

Verified.

@FrederLu FrederLu self-assigned this Jan 30, 2024
@FrederLu FrederLu moved this from 👀 Testing to ✅ Done in CKB Explorer Jan 30, 2024
@github-actions github-actions bot mentioned this issue Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangyouxin zhangyouxin

@FrederLu FrederLu

Labels
enhancement New feature or request
Projects
CKB Explorer
Archived in project
Milestone
No milestone
6 participants
@zhangyouxin @Keith-CY @WhiteMinds @FrederLu @Sven-TBD @Kirl70