Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and actions #3179

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update dependencies and actions #3179

merged 2 commits into from
Sep 5, 2023

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Sep 5, 2023

No description provided.

rejas and others added 2 commits September 5, 2023 08:43
@rejas
Update dependencies
099add8
@dependabot @rejas
Bump actions/checkout from 3 to 4
744336f 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@khassel
Copy link
Collaborator

khassel commented Sep 5, 2023 •
edited
Loading

no changelog? 😱

the failing test was introduced while I was in holidays:

FAIL tests/e2e/ipWhitelist_spec.js (20.715 s)
  ● ipWhitelist directive configuration › Set ipWhitelist without access › should return 403

    FetchError: request to http://localhost:8080/ failed, reason: socket hang up

      at ClientRequest.<anonymous> (node_modules/node-fetch/lib/index.js:1501:11)

  ● ipWhitelist directive configuration › Set ipWhitelist without access › should return 403

This test fails always in my setup when running with node v20. The 2 tests run if they were not started together (e.g. delete one), so sounds like a race condition.

Any ideas?

@khassel khassel merged commit ef20fe2 into MagicMirrorOrg:develop Sep 5, 2023
@rejas
Copy link
Collaborator Author

rejas commented Sep 5, 2023

no changelog? 😱

forgot it / to make it draft :-)

@KristjanESPERANTO
Copy link
Contributor

KristjanESPERANTO commented Sep 5, 2023 •
edited
Loading

This test fails always in my setup when running with node v20. The 2 tests run if they were not started together (e.g. delete one), so sounds like a race condition.

I ran into the same problem when I was working with the internal fetch API. I was able to work around it by giving the two tests different ports (admittedly this is a bit hacky as it addresses the symptom and not the cause): e0b3b01

@khassel
Copy link
Collaborator

khassel commented Sep 5, 2023

Thanks. I prefer to have running tests so we should use the hack until someone finds the root cause ...

Can you provide a PR with your commit?

@KristjanESPERANTO
Copy link
Contributor

Can you provide a PR with your commit?

I'll try to provide it tomorrow 🙂

@KristjanESPERANTO KristjanESPERANTO mentioned this pull request Sep 6, 2023
Closed
@bugsounet bugsounet mentioned this pull request Sep 6, 2023
Merged
@rejas rejas deleted the deps branch September 7, 2023 04:36
@MichMich MichMich mentioned this pull request Oct 1, 2023
Merged
MichMich added a commit that referenced this pull request Oct 1, 2023
@MichMich @khassel
@SkySails @rejas @dWoolridge @retroflex @dariom @MagMar94 @naveensrinivasan @buxxi @Tom-Hirschberger @KristjanESPERANTO @angeldeejay @DaveChild @grenagit @psieg @rajniszp @tomzt @CarJem @nfogal @JakeBinney @OWL4C @oscarb @ismarslomic @jorgenwahlberg @eddiehung @bugsounet @dependabot @Knapoc @sdetweil @Paranoid93 @NolanKingdon @kenzal @Ybbet @TeddyStarinvest @martingron @dgoth
Release v2.25.0 (#3214)
343e7de 
## [2.25.0] - 2023-10-01

Thanks to: @bugsounet, @dgoth, @dependabot, @kenzal, @Knapoc,
@KristjanESPERANTO, @martingron, @NolanKingdon, @Paranoid93,
@TeddyStarinvest and @Ybbet.

Special thanks to @khassel, @rejas and @sdetweil for taking over most
(if not all) of the work on this release as project collaborators. This
version would not be there without their effort. Thank you guys! You are
awesome!

> ⚠️ This release needs nodejs version >= `v18`, older releases have
reached end of life and will not work!

### Added

- Added UV Index support to OpenWeatherMap
- Added 'hideDuplicates' flag to the calendar module
- Added `allowOverrideNotification` to weather module to enable sending
current weather objects with the `CURRENT_WEATHER_OVERRIDE` notification
to supplement/replace the current weather displayed
- Added optional AnimateCSS animate for `hide()`, `show()`,
`updateDom()`
- Added AnimateIn and animateOut in module config definition
- Apply AnimateIn rules on the first start
- Added automatic client page reload when server was restarted by
setting `reloadAfterServerRestart: true` in `config.js`, per default
`false` (#3105)
- Added eventClass option for customEvents on the default calendar
- Added AnimateCSS integration in tests suite (#3206)
- Added npm dependabot [Reserved to developer] (#3210)
- Added improved logging for calendar (#3110)

### Removed

- **Breaking Change**: Removed `digest` authentication method from
calendar module (which was already broken since release `2.15.0`)

### Updated

- Update roboto fonts to version v5
- Update issue template
- Update dev/dependencies incl. electron to v26
- Replace pretty-quick by lint-staged
(<prettier/pretty-quick#164>)
- Update engine node >=18. v16 reached it's end of life. (#3170)
- Update typescript definition for modules
- Cleaned up nunjuck templates
- Replace `node-fetch` with internal fetch (#2649) and remove
`digest-fetch`
- Update the French translation according to the English file.
- Update dependabot incl. vendor/fonts (monthly check)
- Renew `package-lock.json` for release

### Fixed

- Fix engine check on npm install (#3135)
- Fix undefined formatTime method in clock module (#3143)
- Fix clientonly startup fails after async added (#3151)
- Fix electron width/heigth when using xrandr under bullseye
- Fix time issue with certain recurring events in calendar module
- Fix ipWhiteList test (#3179)
- Fix newsfeed: Convert HTML entities, codes and tag in description
(#3191)
- Respect width/height (no fullscreen) if set in electronOptions
(together with `fullscreen: false`) in `config.js` (#3174)
- Fix: AnimateCSS merge hide() and show() animated css class when we do
multiple call
- Fix `Uncaught SyntaxError: Identifier 'getCorsUrl' has already been
declared (at utils.js:1:1)` when using `clock` and `weather` module
(#3204)
- Fix overriding `config.js` when running tests (#3201)
- Fix issue in weathergov provider with probability of precipitation not
showing up on hourly or daily forecast

---------

Signed-off-by: naveen <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Karsten Hassel <[email protected]>
Co-authored-by: Malte Hallström <[email protected]>
Co-authored-by: Veeck <[email protected]>
Co-authored-by: veeck <[email protected]>
Co-authored-by: dWoolridge <[email protected]>
Co-authored-by: Johan <[email protected]>
Co-authored-by: Dario Mratovich <[email protected]>
Co-authored-by: Dario Mratovich <[email protected]>
Co-authored-by: Magnus <[email protected]>
Co-authored-by: Naveen <[email protected]>
Co-authored-by: buxxi <[email protected]>
Co-authored-by: Thomas Hirschberger <[email protected]>
Co-authored-by: Kristjan ESPERANTO <[email protected]>
Co-authored-by: Andrés Vanegas Jiménez <[email protected]>
Co-authored-by: Dave Child <[email protected]>
Co-authored-by: grenagit <[email protected]>
Co-authored-by: Grena <[email protected]>
Co-authored-by: Magnus Marthinsen <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Piotr Rajnisz <[email protected]>
Co-authored-by: Suthep Yonphimai <[email protected]>
Co-authored-by: CarJem Generations (Carter Wallace) <[email protected]>
Co-authored-by: Nicholas Fogal <[email protected]>
Co-authored-by: JakeBinney <[email protected]>
Co-authored-by: OWL4C <[email protected]>
Co-authored-by: Oscar Björkman <[email protected]>
Co-authored-by: Ismar Slomic <[email protected]>
Co-authored-by: Jørgen Veum-Wahlberg <[email protected]>
Co-authored-by: Eddie Hung <[email protected]>
Co-authored-by: Bugsounet - Cédric <[email protected]>
Co-authored-by: bugsounet <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Knapoc <[email protected]>
Co-authored-by: sam detweiler <[email protected]>
Co-authored-by: veeck <[email protected]>
Co-authored-by: Paranoid93 <[email protected]>
Co-authored-by: NolanKingdon <[email protected]>
Co-authored-by: J. Kenzal Hunter <[email protected]>
Co-authored-by: Teddy <[email protected]>
Co-authored-by: TeddyStarinvest <[email protected]>
Co-authored-by: martingron <[email protected]>
Co-authored-by: dgoth <[email protected]>
@Ybbet Ybbet mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rejas @khassel @KristjanESPERANTO