v2.24.0 - Clock module - (showSunTimes: true) Retruns Undefined - formatTime is not defined

[fire1ce]

MagicMirror v2.24.0

Clock module:

I've commneted it to render the clock black.

    {
      module: 'clock',
      position: 'top_bar',
      config: {
        clockBold: true,
        // showSunTimes: true,
        displayType: 'both',
        analogSize: '400px',
        analogPlacement: 'right',
        secondsColor: '#ff5263',
        lat: xx.xx,
        lon: xx.xx,
      },
    }

when showSunTimes: true
error from the console:

clock.js:191 Uncaught (in promise) ReferenceError: formatTime is not defined
    at Class.getDom (clock.js:191:5)
    at main.js:110:35
    at new Promise (<anonymous>)
    at updateDom (main.js:108:10)
    at main.js:53:31
    at Array.forEach (<anonymous>)
    at createDomObjects (main.js:20:11)
    at Object.modulesStarted (main.js:485:4)
    at startModules (loader.js:42:6)
    at async loadNextModule (loader.js:218:6)

[khassel]

tested your above config with

lat: 50,
lon: 8,

without getting an error

[rejas]

You got to enable showSunTimes @khassel then you can reprdocue it. Got a fix ready, but wanted to write tests for it before submitting.

[khassel]

enabled it, works for me with this config

    {
      module: 'clock',
      position: 'top_bar',
      config: {
        clockBold: true,
        showSunTimes: true,
        displayType: 'both',
        analogSize: '400px',
        analogPlacement: 'right',
        secondsColor: '#ff5263',
        lat: 50,
        lon: 8,
      },
    },

[fire1ce]

enabled it, works for me with this config

    {
      module: 'clock',
      position: 'top_bar',
      config: {
        clockBold: true,
        showSunTimes: true,
        displayType: 'both',
        analogSize: '400px',
        analogPlacement: 'right',
        secondsColor: '#ff5263',
        lat: 50,
        lon: 8,
      },
    },

Tested with this clock config, Having the same issue. ¯_(ツ)_/¯

[fire1ce]

Btw, it happen since the last version only.

[khassel]

o.k., now I can reproduce it.

I had a weather module before the clock config in config.js and the weather module loads the missing script so the clock module works in this case. If I move the clock config at first place I get the error.

[fire1ce]

o.k., now I can reproduce it.

I had a weather module before the clock config in config.js and the weather module loads the missing script so the clock module works in this case. If I move the clock config at first place I get the error.

Nothing better then possibility to reproduce a bug. On second thought no bugs is better 😶

Thanks for your work!

[wbleek]

This issue might not be fixed entirely because it also appears when selection the time zone by text instead of lon and lat parameter. See issue #3262