Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct region name to ISMIP6 Greenland Regions #875

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mark-petersen
Copy link
Collaborator

Region group name in files_for_e3sm diagnostic masks did not match geometric features. After correcting, this works for IcoswISC240.

@xylar
Copy link
Collaborator

xylar commented Dec 17, 2024

@mark-petersen, can you describe in more detail the test you ran (which machine, which compilers, etc.)?

I'll merge as soon as CI passes and this more detailed description gets added.

@xylar
Copy link
Collaborator

xylar commented Dec 17, 2024

This update was missed in #874 when geometric_features was updated to v1.6.0.

@xylar xylar added bug Something isn't working ocean labels Dec 17, 2024
@xylar xylar self-assigned this Dec 17, 2024
@xylar xylar self-requested a review December 17, 2024 16:55
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks right to me!

@mark-petersen
Copy link
Collaborator Author

mark-petersen commented Dec 17, 2024

Tested on chicoma by running

 220: ocean/global_ocean/IcoswISC240/mesh
 221: ocean/global_ocean/IcoswISC240/WOA23/init
 229: ocean/global_ocean/IcoswISC240/WOA23/dynamic_adjustment
 230: ocean/global_ocean/IcoswISC240/WOA23/files_for_e3sm
compass setup -n 220 221 229 230 -p $e/master/components/mpas-ocean -w $r/251217_test_files_for_e3sm

I was able to compass run within files_for_e3sm/diagnostic_masks and it ran all the way through and produced the expected files. Before this fix it ends with an error

  File "/usr/projects/climate/mpeterse/repos/compass/main/compass/ocean/tests/global_ocean/files_for_e3sm/diagnostic_masks.py", line 92, in make_diagnostics_files
    function, prefix, date = get_aggregator_by_name(region_group)
                             ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/usr/projects/climate/mpeterse/miniforge3/envs/dev_compass_1.6.0-alpha.2/lib/python3.13/site-packages/geometric_features/aggregation/__init__.py", line 78, in get_aggregator_by_name
    raise ValueError(f'Unknown region group {region_group}')
ValueError: Unknown region group Greenland Regions

@xylar
Copy link
Collaborator

xylar commented Dec 17, 2024

Thanks @mark-petersen for discovering the issue and fixing it!

@xylar xylar merged commit e4d53af into MPAS-Dev:main Dec 17, 2024
6 checks passed
@xylar xylar deleted the correct-greenland-region branch December 17, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants