Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.13 support and make it the default #874

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 3, 2024

This merge also updates mpas_tools to 0.36.0 and geometric_features to 1.6.0, the latest versions. Thus, it bumps compass to 1.6.0-alpha.2.

Some unused files are removed.

Checklist

  • Developer's Guide has been updated
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar requested a review from altheaden December 3, 2024 16:04
@xylar xylar self-assigned this Dec 3, 2024
@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Dec 3, 2024
@altheaden
Copy link
Collaborator

@xylar What you have now looks good to me. I think you also want to add 3.13 to the setup.py. There is also a mention of the latest python version in docs/developers_guide/quick_start.rst which you might want to update as well. I also see a mention of 3.12 in the conda/default.cfg but I'm not sure if that is something you'd want to update. I have these changes in a branch right now, so if you'd like I can push any or all of those here.

@altheaden
Copy link
Collaborator

@xylar just pushed those changes for you!

Copy link
Collaborator

@altheaden altheaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now.

@xylar xylar changed the title Add python 3.13 support Add python 3.13 support and make it the default Dec 3, 2024
@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2024

I feel like I should run the pr suite on Chrysalis to avoid any surprises now that python 3.13 has become the default.

@altheaden
Copy link
Collaborator

Let me know if you'd like me to do any testing as well.

@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2024

Testing

I ran the pr suite on Chrysalis with Intel and OpenMPI. All tests passed successfully.

@xylar xylar merged commit 9376468 into MPAS-Dev:main Dec 3, 2024
6 checks passed
@xylar xylar deleted the add-python-3.13 branch December 3, 2024 17:21
@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2024

@altheaden, thanks for your help debugging and reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants