Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix to snow melt for E3SM V2 #647

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Bug fix to snow melt for E3SM V2 #647

merged 1 commit into from
Aug 6, 2020

Conversation

proteanplanet
Copy link

This fixes snow melt according to the Icepack bug fix at:

CICE-Consortium/Icepack#328

@jonbob jonbob added the Sea ice label Aug 5, 2020
@jonbob jonbob requested review from akturner and njeffery August 5, 2020 23:14
@jonbob jonbob added bug bug fix and removed bug labels Aug 5, 2020
njeffery
njeffery approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@njeffery njeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the standard testsuite runs and was BFB in the regression test.
This fix properly corrects an omission in the snow melt variable.

@akturner akturner merged commit df5184f into MPAS-Dev:seaice/develop Aug 6, 2020
akturner
akturner reviewed Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@akturner akturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes all tests

@akturner akturner mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akturner akturner akturner left review comments

@njeffery njeffery njeffery approved these changes

Assignees

@akturner akturner

Labels
bug fix Sea ice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@proteanplanet @akturner @njeffery @matthewhoffman @jonbob