Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpas-source: fixes sea ice melt bug #3796

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Update mpas-source: fixes sea ice melt bug #3796

merged 1 commit into from
Aug 27, 2020

Conversation

akturner
Copy link
Contributor

@akturner akturner commented Aug 26, 2020 •
edited by jonbob
Loading

This corrects a bug in the snow melt diagnostic part of the column package in MPAS-Seaice. When the sea ice completely melts away in the thermodynamics, the final little bit of snow melt is not added to the melts array.

see MPAS PR MPAS-Dev/MPAS-Model#647

Fixes #3795

[non-BFB] potentially for tests with active seaice

@jonbob jonbob requested a review from darincomeau August 26, 2020 22:08
darincomeau
darincomeau approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection.

jonbob added a commit that referenced this pull request Aug 26, 2020
@jonbob
Merge branch 'akturner/seaice/fixmeltbug' into next (PR #3796)
4be71f7 
Update mpas-source: fixes sea ice melt bug

This corrects a bug in the snow melt diagnostic part of the column package in
MPAS-Seaice. When the sea ice completely melts away in the thermodynamics, the
final little bit of snow melt is not added to the melts array.

see MPAS PR #647

Fixes #3795

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Aug 26, 2020

merged to next

@jonbob jonbob added the non-BFB PR makes roundoff changes to answers. label Aug 27, 2020
@jonbob jonbob merged commit 188326e into master Aug 27, 2020
@jonbob
Copy link
Contributor

jonbob commented Aug 27, 2020

Merged to master and DIFFs blessed on compy

@jonbob jonbob deleted the akturner/seaice/fixmeltbug branch August 27, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darincomeau darincomeau darincomeau approved these changes

Assignees

@jonbob jonbob

Labels
bug fix PR mpas-seaice non-BFB PR makes roundoff changes to answers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sea ice snow melt diagnostic bug
3 participants
@akturner @jonbob @darincomeau