Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PRT): revise mf6io and supptechinfo #1833

Merged
merged 4 commits into from
May 21, 2024

Conversation

wpbonelli
Copy link
Contributor

Incorporate suggestions after review

@wpbonelli wpbonelli requested a review from aprovost-usgs May 20, 2024 15:22
Copy link
Contributor

@aprovost-usgs aprovost-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes. If there are any other issues from Richard's review the remain to be resolved, we can discuss

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:
The cell centroid calculated by PRT is not necessarily identical to the cell center specified by the user for a DISV grid.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup:

For the description of the w's in eqns 11-1 and 11-2 in supptechinfo:
After the phrase describing "subscripted v", which ends with "direction, ", insert "and subscripted w (1/T) indicates the constant rate at which a velocity component changes with xtilde or ytilde." Then start a new sentence to describe xtilde and ytilde: "The coordinates xtilde and ytilde are Cartesian coordinates ..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding
"Explicit release times and release settings configured in the period block are additive and can be mixed and matched."
(Two instances) Thinking maybe there's another place to mention this -- discuss?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-generated, so won't comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-generated, so won't comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-generated, so won't comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-generated ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:
To accommodate non-rectangular cells, the face numbering scheme in the PRT Model is based on clockwise ordering of the cell faces. For a DIS-grid cell, face 1 is the ``northern" face, i.e., the face parallel to the $x$ axis that has the greater $y$ coordinate. For a DISV-grid cell, face 1 is the face that extends in the clockwise direction from the first vertex listed for that cell in the CELL2D input block.
(Note: will want to check the statement about the northern face being #1 to make sure it's true)

Copy link
Contributor

@aprovost-usgs aprovost-usgs May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup:

checked the IFLOWFACE (PRT) ordering for a DIS-grid cell, and I had it wrong in my review. Face 1 is the "western" face, i.e., the face parallel to the y axis that has the lesser x coordinate. Might want to put the subsection about IFLOWFACE before the subsection on Output.

also, checked the IFACE (MODPATH 7) ordering, and it's "left, right, front, back, bottom, and top." Think I had erroneously written "back, front" in the supptechinfo chapter. can't remember if it also appears in mf6io, though don't think so

@wpbonelli wpbonelli marked this pull request as ready for review May 21, 2024 13:00
@wpbonelli wpbonelli merged commit 3ee1283 into MODFLOW-USGS:develop May 21, 2024
4 of 7 checks passed
@wpbonelli wpbonelli deleted the prt-revisions branch May 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants