Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sfr): resolve divide by zero issue #1633

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

jdhughes-usgs
Copy link
Contributor

closes #1585

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to update release notes

@wpbonelli wpbonelli merged commit 1ae17de into MODFLOW-USGS:develop Feb 19, 2024
15 checks passed
@jdhughes-usgs jdhughes-usgs deleted the fix-1585 branch February 20, 2024 14:01
jdhughes-usgs added a commit to jdhughes-usgs/modflow6 that referenced this pull request Feb 20, 2024
* add description of the bug fixed by PR MODFLOW-USGS#1633
* extend test_gwf_sfr_inactive autotest to reactive sfr reaches after inactivating 3 of 6 reaches
jdhughes-usgs added a commit that referenced this pull request Feb 20, 2024
* add description of the bug fixed by PR #1633
* extend test_gwf_sfr_inactive autotest to reactivate sfr reaches after inactivating 3 of 6 reaches
* update test_gwf_sfr_inactive autotest test description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sfr fails to deal with downstream inactive reaches correctly.
3 participants