Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sfr fails to deal with downstream inactive reaches correctly. #1585

Closed
rbwinst-usgs opened this issue Feb 5, 2024 · 0 comments · Fixed by #1633
Closed

Sfr fails to deal with downstream inactive reaches correctly. #1585

rbwinst-usgs opened this issue Feb 5, 2024 · 0 comments · Fixed by #1633
Labels
bug

Comments

@rbwinst-usgs
Copy link

Describe the bug
If a reach is connected to one or more downstream reaches and all the downstream reaches are inactive, MODFLOW terminates with a divide-by-zero error.

To reproduce
Steps to reproduce the behavior:
Run the attached model. It runs correctly for stress period 1 but crashes in stress period 2 with a downstsream reach becomes inactive.

Expected behavior
Either of the following

  1. MODFLOW terminates with an error message.
  2. MODFLOW treats the reach has having no downstream reaches to which flow should be routed.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Environment

  • Operating system (e.g. macOS, Linux, Windows) and version
  • MODFLOW 6 version (if installed via distribution)
  • Compiler toolchain/version (if built from source)
    SfrBug.zip
jdhughes-usgs added a commit to jdhughes-usgs/modflow6 that referenced this issue Feb 18, 2024
@jdhughes-usgs
fix(sfr): resolve divide by zero issue
2d631b5 
* add test that replicates test model provided in issue MODFLOW-USGS#1585

closes MODFLOW-USGS#1585
@jdhughes-usgs jdhughes-usgs mentioned this issue Feb 18, 2024
Merged
wpbonelli pushed a commit to jdhughes-usgs/modflow6 that referenced this issue Feb 19, 2024
@jdhughes-usgs @wpbonelli
fix(sfr): resolve divide by zero issue
785b0fd 
* add test that replicates test model provided in issue MODFLOW-USGS#1585

closes MODFLOW-USGS#1585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sfr): resolve divide by zero issue jdhughes-usgs/modflow6
1 participant
@rbwinst-usgs