Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bye bye PHP 8.1, long live PHP 8.2 #2060

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Bye bye PHP 8.1, long live PHP 8.2 #2060

merged 6 commits into from
Dec 21, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 20, 2023

DO NOT MERGE BEFORE 25 Nov 2023

Kill compatibility with PHP 8.1 (EOL).
Support PHP 8.3 released November 23, 2023

Changes in the imagerotate() function between php8.2 and php8.3 broke one of the dependency (thecodingmachine/safe). :(

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (31e706a) 84.22% compared to head (ea91b8b) 83.83%.

Additional details and impacted files

@ildyria ildyria marked this pull request as draft November 20, 2023 17:49
@ildyria ildyria force-pushed the rip-8.1 branch 2 times, most recently from e923047 to 9cf1d05 Compare November 27, 2023 20:39
@ildyria ildyria added this to the 5.0.0 milestone Dec 21, 2023
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Dec 21, 2023
@ildyria ildyria marked this pull request as ready for review December 21, 2023 11:26
@ildyria ildyria requested a review from a team December 21, 2023 11:27
@ildyria ildyria merged commit 573e725 into master Dec 21, 2023
23 checks passed
@ildyria ildyria deleted the rip-8.1 branch December 21, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants