unfortunately new phpstan is stupid

LycheeOrg · Nov 27, 2023 · 9cf1d05 · 9cf1d05
1 parent b66b7b5
commit 9cf1d05
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/app/Actions/Album/Archive.php b/app/Actions/Album/Archive.php
@@ -179,14 +179,14 @@ private function compressAlbum(AbstractAlbum $album, array &$usedDirNames, ?stri
 			return;
 		}
 
-		$fullNameOfDirectory = $this->makeUnique(self::createValidTitle($album->title), $usedDirNames);
+		$fullNameOfDirectory = $this->makeUnique(self::createValidTitle($album->title), $usedDirNames); // @phpstan-ignore-line
 		if ($fullNameOfParent !== '') {
 			$fullNameOfDirectory = $fullNameOfParent . '/' . $fullNameOfDirectory;
 		}
 
 		$usedFileNames = [];
 		// TODO: Ensure that the size variant `original` for each photo is eagerly loaded as it is needed below. This must be solved in close coordination with `ArchiveAlbumRequest`.
-		$photos = $album->photos;
+		$photos = $album->photos; // @phpstan-ignore-line
 
 		/** @var Photo $photo */
 		foreach ($photos as $photo) {

diff --git a/app/Actions/Album/PositionData.php b/app/Actions/Album/PositionData.php
@@ -40,6 +40,6 @@ public function get(AbstractAlbum $album, bool $includeSubAlbums = false): Posit
 			->whereNotNull('latitude')
 			->whereNotNull('longitude');
 
-		return new PositionDataResource($album->id, $album->title, $photoRelation->get(), $album instanceof Album ? $album->track_url : null);
+		return new PositionDataResource($album->id, $album->title, $photoRelation->get(), $album instanceof Album ? $album->track_url : null); // @phpstan-ignore-line
 	}
 }
diff --git a/app/Actions/Photo/Strategies/AddStandaloneStrategy.php b/app/Actions/Photo/Strategies/AddStandaloneStrategy.php
@@ -159,7 +159,7 @@ public function do(): Photo
 			// The original and final checksum may differ, if the photo has
 			// been rotated by `putSourceIntoFinalDestination` while being
 			// moved into final position.
-			$this->photo->checksum = $streamStat->checksum;
+			$this->photo->checksum = $streamStat->checksum;  // @phpstan-ignore-line
 			$this->photo->save();
 
 			// Create original size variant of photo
@@ -173,7 +173,7 @@ public function do(): Photo
 				SizeVariantType::ORIGINAL,
 				$targetFile->getRelativePath(),
 				$imageDim,
-				$streamStat->bytes
+				$streamStat->bytes // @phpstan-ignore-line
 			);
 		} catch (LycheeException $e) {
 			// If source file could not be put into final destination, remove

diff --git a/app/Actions/Photo/Strategies/RotateStrategy.php b/app/Actions/Photo/Strategies/RotateStrategy.php
@@ -107,15 +107,15 @@ public function do(): Photo
 
 		// The checksum has been changed due to rotation.
 		$oldChecksum = $this->photo->checksum;
-		$this->photo->checksum = $streamStat->checksum;
+		$this->photo->checksum = $streamStat->checksum; // @phpstan-ignore-line
 		$this->photo->save();
 
 		// Re-create original size variant of photo
 		$newOriginalSizeVariant = $this->photo->size_variants->create(
 			SizeVariantType::ORIGINAL,
 			$targetFile->getRelativePath(),
 			$image->getDimensions(),
-			$streamStat->bytes
+			$streamStat->bytes // @phpstan-ignore-line
 		);
 
 		// Re-create remaining size variants

diff --git a/app/Jobs/ProcessImageJob.php b/app/Jobs/ProcessImageJob.php
@@ -50,7 +50,7 @@ public function __construct(
 	) {
 		$this->filePath = $file->getPath();
 		$this->originalBaseName = $file->getOriginalBasename();
-		$this->albumID = is_string($albumID) ? $albumID : $albumID?->id;
+		$this->albumID = is_string($albumID) ? $albumID : $albumID?->id;  // @phpstan-ignore-line
 		$this->userId = Auth::user()->id;
 		$this->fileLastModifiedTime = $fileLastModifiedTime;