Merge gallery, view and frame Into a Unified Frontend

app/Actions/Diagnostics/Info.php

@@ -39,7 +39,7 @@ public function get(): array
 		// About Imagick version
 		$imagick = extension_loaded('imagick');
 		if ($imagick === true) {
-			$imagickVersion = Imagick::getVersion();
+			$imagickVersion = \Imagick::getVersion();
 		} else {
 			// @codeCoverageIgnoreStart
 			$imagick = '-';

app/Actions/Import/FromServer.php

@@ -50,6 +50,8 @@ protected function determineMemLimit(): int
 		$value = 0;
 		$suffix = '';
 		if (sscanf(ini_get('memory_limit'), '%d%c', $value, $suffix) === 2) {
+			/** @var int $value */
+			/** @var string $suffix */
 			switch (strtolower($suffix)) {
 				// @codeCoverageIgnoreStart
 				case 'k':
@@ -68,6 +70,8 @@ protected function determineMemLimit(): int
 					break;
 					// @codeCoverageIgnoreEnd
 			}
+		} else {
+			$value = 0;
 		}
 
 		// We set the warning threshold at 90% of the limit.

app/Actions/Photo/Archive.php

@@ -12,7 +12,6 @@
 use App\Models\Configs;
 use App\Models\Photo;
 use App\Models\SizeVariant;
-use DateTimeInterface;
 use Illuminate\Database\Eloquent\Collection;
 use Safe\Exceptions\InfoException;
 use function Safe\fclose;
@@ -160,7 +159,7 @@ protected function file(Photo $photo, string $variant): StreamedResponse
 				$photo->updated_at->toAtomString() .
 				$archiveFileInfo->getFile()->getFilesize())
 			);
-			$response->headers->set('Last-Modified', $photo->updated_at->format(DateTimeInterface::RFC7231));
+			$response->headers->set('Last-Modified', $photo->updated_at->format(\DateTimeInterface::RFC7231));
 
 			return $response;
 		} catch (\InvalidArgumentException $e) {

app/Assets/Helpers.php

@@ -3,12 +3,9 @@
 namespace App\Assets;
 
 use App\Exceptions\Internal\ZeroModuloException;
-use Illuminate\Contracts\Container\BindingResolutionException;
 use Illuminate\Support\Facades\File;
-use function Safe\getallheaders;
 use function Safe\ini_get;
 use function Safe\parse_url;
-use WhichBrowser\Parser as BrowserParser;
 
 class Helpers
 {
@@ -42,32 +39,6 @@ public function cacheBusting(string $filePath): string
 		return $filePath;
 	}
 
-	/**
-	 * Returns the device type as string:
-	 * desktop, mobile, pda, dect, tablet, gaming, ereader,
-	 * media, headset, watch, emulator, television, monitor,
-	 * camera, printer, signage, whiteboard, devboard, inflight,
-	 * appliance, gps, car, pos, bot, projector.
-	 *
-	 * This method is only used to report the type of device back to the
-	 * client.
-	 * This is totally insane, because the client knows its own type anyway.
-	 * This could be completely done in JS code and CSS on the client side.
-	 * See also {@link ConfigFunctions::get_config_device()}.
-	 *
-	 * TODO: Remove this method.
-	 *
-	 * @return string
-	 *
-	 * @throws BindingResolutionException
-	 */
-	public function getDeviceType(): string
-	{
-		$result = new BrowserParser(getallheaders(), ['cache' => app('cache.store')]);
-
-		return $result->getType();
-	}
-
 	/**
 	 * Return the 32bit truncated version of a number seen as string.
 	 *

app/Console/Commands/Sync.php

@@ -116,7 +116,7 @@ public function handle(): int
 			foreach ($directories as $directory) {
 				try {
 					$exec->do($directory, $album);
-				} catch (Exception $e) {
+				} catch (\Exception $e) {
 					$this->error($e);
 				}
 			}

app/DTO/ArrayableDTO.php

@@ -4,8 +4,6 @@
 
 use App\Exceptions\Internal\LycheeLogicException;
 use Illuminate\Contracts\Support\Arrayable;
-use ReflectionClass;
-use ReflectionProperty;
 
 /**
  * In some cases, when a DTO does not need to apply casts on attributes
@@ -22,8 +20,8 @@ class ArrayableDTO extends DTO
 	public function toArray(): array
 	{
 		$result = [];
-		$cls = new ReflectionClass($this);
-		$props = $cls->getProperties(ReflectionProperty::IS_PUBLIC);
+		$cls = new \ReflectionClass($this);
+		$props = $cls->getProperties(\ReflectionProperty::IS_PUBLIC);
 		foreach ($props as $prop) {
 			$value = $prop->getValue($this);
 			if (is_object($value)) {

app/Facades/Helpers.php

@@ -12,7 +12,6 @@
  * Keep the list of documented method in sync with {@link \App\Assets\Helpers}.
  *
  * @method static string cacheBusting(string $filePath)
- * @method static string getDeviceType()
  * @method static string trancateIf32(string $id, int $prevShortId = 0)
  * @method static string getExtension(string $filename, bool $isURI = false)
  * @method static bool   hasPermissions(string $path)