Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge gallery, view and frame Into a Unified Frontend #1522

Merged
merged 28 commits into from
Nov 26, 2022
Merged

Merge gallery, view and frame Into a Unified Frontend #1522

merged 28 commits into from
Nov 26, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented Sep 19, 2022 •
edited
Loading

The primary purpose of this PR is to sync LycheeOrg/Lychee-front#323, but is also has some merits on its own:

  • Cleans up some of the configuration options
  • Removes and simplifies everything which is not needed anymore on the backend, because the frontend takes care of those things on its own
  • It also removes the left-over of the "page" mode which has already been removed by Drop page support #1489, but failed to clean up completely.

@nagmat84 nagmat84 changed the title Merge modes Merge frontend modes "view", "frame" and "gallery" into one. Sep 19, 2022
@nagmat84 nagmat84 changed the title Merge frontend modes "view", "frame" and "gallery" into one. Merge frontend modes "view", "frame" and "gallery" into one Sep 19, 2022
@nagmat84 nagmat84 changed the title Merge frontend modes "view", "frame" and "gallery" into one Merge Frontend Modes gallery, view and frame Into a Unified Frontend Sep 19, 2022
@ildyria
Copy link
Member

ildyria commented Sep 20, 2022

I am not sure yet about that way of dropping /frame, but I am curious of what it will look like.

@nagmat84 nagmat84 mentioned this pull request Sep 22, 2022
Merged
@nagmat84 nagmat84 marked this pull request as ready for review September 22, 2022 18:06
@nagmat84 nagmat84 requested a review from a team September 22, 2022 18:06
@nagmat84 nagmat84 force-pushed the merge_modes branch 2 times, most recently from 05fcfb7 to 03f17c4 Compare September 24, 2022 18:13
@nagmat84 nagmat84 force-pushed the merge_modes branch 3 times, most recently from 7addaf4 to 7b92969 Compare October 19, 2022 12:36
@nagmat84 nagmat84 requested a review from a team October 19, 2022 17:11
@nagmat84 nagmat84 mentioned this pull request Oct 19, 2022
Merged
qwerty287
qwerty287 reviewed Oct 20, 2022
View reviewed changes
public/frontend.html Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 21, 2022 •
edited
Loading

Codecov Report

Merging #1522 (3417d3f) into master (231075e) will decrease coverage by 1.04%.
The diff coverage is 60.00%.

Additional details and impacted files

kamil4
kamil4 previously requested changes Oct 21, 2022
View reviewed changes
database/migrations/2022_09_18_143201_make_wui_settings_public.php Outdated Show resolved Hide resolved
app/Http/Controllers/ViewController.php Outdated Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
@ildyria ildyria added this to the 4.6.3 milestone Oct 28, 2022
@nagmat84 nagmat84 mentioned this pull request Nov 1, 2022
Merged
ildyria
ildyria approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested.

@ildyria
Copy link
Member

ildyria commented Nov 21, 2022

@kamil4 Need your checks. :)
@nagmat84 resolved conflicts.

@ildyria ildyria dismissed kamil4’s stale review November 26, 2022 16:19

Changes have been addressed.

@ildyria ildyria changed the title Merge Frontend Modes gallery, view and frame Into a Unified Frontend Merge gallery, view and frame Into a Unified Frontend Nov 26, 2022
@ildyria ildyria merged commit c5ef10c into master Nov 26, 2022
@ildyria ildyria deleted the merge_modes branch November 26, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 left review comments

@kamil4 kamil4 kamil4 left review comments

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nagmat84 @ildyria @kamil4 @qwerty287