-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update ConvMixer to support reactant #1063
base: ap/reactant_updates
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 82.83% 76.31% -6.53%
==========================================
Files 147 145 -2
Lines 6072 6049 -23
==========================================
- Hits 5030 4616 -414
- Misses 1042 1433 +391 ☔ View full report in Codecov by Sentry. |
090b87e
to
23ed44b
Compare
db3a12d
to
ef770a9
Compare
Benchmark Results (ASV)
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
25f13de
to
ee2fb4f
Compare
b0709d4
to
442bb41
Compare
a60c1de
to
017076f
Compare
dc5e56e
to
fee949f
Compare
Not completely functional yet "error: expects input feature dimension (256) / feature_group_count = kernel input feature dimension (256). Got feature_group_count = 256." xref: EnzymeAD/Reactant.jl#331 |
438fede
to
e3ab45f
Compare
Unfortunately there is a strong discrepancy in the gradients between Zygote and Reactant. Need to debug |
d646b75
to
a7fb9c9
Compare
8e1ba6a
to
644b60c
Compare
9b9f537
to
05500f2
Compare
CUDA.allowscalar(false) | ||
|
||
@isdefined(includet) ? includet("common.jl") : include("common.jl") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
conv
gradient is not implemented in EnzymeJAX EnzymeAD/Reactant.jl#214reduce_window
adjoint -- we could potentially work around this