Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secure OD struct to not compile in case of access violation. fix #295 #421

Merged
merged 22 commits into from
Mar 28, 2023
Merged

secure OD struct to not compile in case of access violation. fix #295 #421

merged 22 commits into from
Mar 28, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Feb 6, 2023 •
edited by JeromeGalan
Loading

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • New feature (non-breaking change which adds functionality)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault linked an issue Feb 6, 2023 that may be closed by this pull request
[NEW FEATURE] Secure OD structure usage avoiding users to directly set it #295
Closed
@nicolas-rabault nicolas-rabault self-assigned this Feb 6, 2023
@nicolas-rabault nicolas-rabault removed the request for review from JeromeGalan February 7, 2023 08:35
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_OD branch 9 times, most recently from 127d1bd to 2faca96 Compare February 13, 2023 16:01
@nicolas-rabault
Copy link
Member Author

This PR will close #407

@nicolas-rabault nicolas-rabault changed the title secure OD struct to not compile in case of access voilation. fix #295 secure OD struct to not compile in case of access violation. fix #295 Feb 14, 2023
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_OD branch 3 times, most recently from 1f6e3a4 to 227cbb6 Compare February 14, 2023 17:34
@nicolas-rabault nicolas-rabault added this to the 2.9.0 milestone Feb 17, 2023
JeromeGalan
JeromeGalan approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Good

@JeromeGalan JeromeGalan merged commit de61fb9 into rc_2.9.0 Mar 28, 2023
@JeromeGalan JeromeGalan deleted the feat/secure_OD branch March 28, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] Secure OD structure usage avoiding users to directly set it
2 participants
@nicolas-rabault @JeromeGalan