changed structure in od_angular.h

[Faizan711]

@Simonbdy submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

• Ensure that this PR is not a duplicate.
• Assign @Simonbdy to this PR
• Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

This PR is regarding a change in structure mentioned in issue #295.

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.
Here i have changed the typedef structure to struct only in the od_angular.h file in OD directory and i want you to verify the change , so i can make the changes to the rest of the files in the OD directory if correct. If something is wrong i will modify it accordingly.

Changes

Please choose the relevant options:

• New feature (non-breaking change which adds #functionality)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

issue number #295

WARNING: Do not edit the checklist below.

---

Developer section

• [Documentation] is up to date with new feature
• [Tests] are passed OK (non regression, new features & bug fixes)
• [Code Quality] please check if:
  • Each function has a header (description, inputs, outputs)
  • Code is commented (particularly in hard to understand areas)
  • There are no new warnings that can be corrected
  • Commits policy is respected (constitancy commits, clear commits comments)

QA section

• [Review] tests for new features have been reviewed
• [Changelog] is up-to-date with expected tags
  🆕 Feature: [Feature] Description...
  🆕 Added: [Feature] Description...
  🆕 Changed: [Feature] Description...
  🛠️ Fix: [Feature] Description...

[nicolas-rabault]

Sounds good!
I just spotted a strange line and some clarity improvement.
Also perhaps there is some cast missing, we will have to watch for compilation warnings...
I also enable the bot, so you can consult the result on the bottom.

[Faizan711]

should i close this PR and make a PR again after correcting my mistakes??

[Simonbdy]

should i close this PR and make a PR again after correcting my mistakes??

@Faizan711, you can make as many loops and corrections as needed in this PR. No need to open a new PR for each correction. Eventually when everything is smooth and reviewed we will merge it.

[Faizan711]

@Simonbdy , @nicolas-rabault I have made the corrections mentioned. Please check this and let me know if its correct.

[nicolas-rabault]

Watch out not everything should be just self. When you return float values you need to use self.private because it's a float value.

[Faizan711]

@nicolas-rabault I have made the corrections for float values, please check and let me know if it is correct, if not i will make the corrections again.

[nicolas-rabault]

You should try to compile a code example using this code and look at the compilation errors to check it out first.
Our GitHub action bot spotted some mistakes here : https://github.com/Luos-io/luos_engine/actions/runs/3639529878/jobs/6143038302
You can try to compile examples/projects/native/button/ project. This is a simple one able to run on your computer.

[Faizan711]

OK i will try to compile, if i get issues i will connect with you here or in discord.

[nicolas-rabault]

For compilation issue Discord is more appropriate, because it's (probably) not directly linked to this particular PR.

[Faizan711]

Sorry @nicolas-rabault i was inactive for few days due to my exams. I need some help on how to run the updated script. I also dropped a message in discord but didn't got any response, can you please provide some help?

[nicolas-rabault]

I don't know what you mean by updated script.

[Faizan711]

Sorry i was unclear, i meant the file in which i have made changes. The one named od_angluar.h

[nicolas-rabault]

By modifying the file on your local version of Luos_engine and compile the native example I mention Platformio will compile your modified file and display your potential mistakes.

[nicolas-rabault]

This Issue have been addresed already in 2.9.0