Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] storage_media_product: Migration to 18.0 #1

Open
wants to merge 34 commits into
base: 18.0
Choose a base branch
from

Conversation

LucasTran380381
Copy link
Owner

@LucasTran380381 LucasTran380381 commented Jan 7, 2025

Base on:

https://github.com/OCA/storage/pull/294

Depends:

https://github.com/OCA/storage/pull/435
https://github.com/OCA/storage/pull/434
https://github.com/OCA/storage/pull/438

Result:

image
Product Test has 2 variants and media file config with each variant

In each variant we has specific medias
image
image

sebastienbeau and others added 30 commits January 7, 2025 15:14
This PR fixes the media displayed on the product variant form in the media
tab.

The change on the depends force the recomputation when an attibute value
is changed on the product.media.relation.

The other change fixes the attributes value that are tested to assign
a media on a variant.
It is the attribute set on the product variant that should be used and
not all attribute values assigned to the product template.

Forward port from:

* OCA#116
@LucasTran380381 LucasTran380381 marked this pull request as draft January 7, 2025 11:02
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-storage_media_product branch from ffd0e6f to 23d6906 Compare January 7, 2025 11:18
@LucasTran380381 LucasTran380381 marked this pull request as ready for review January 7, 2025 11:21
Copy link

@Kimkhoi3010 Kimkhoi3010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.