forked from OCA/storage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] storage_media_product: Migration to 18.0 #1
Open
LucasTran380381
wants to merge
34
commits into
18.0
Choose a base branch
from
18.0-mig-storage_media_product
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and storage_media_product
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
ffd0e6f
to
23d6906
Compare
Kimkhoi3010
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on:
https://github.com/OCA/storage/pull/294
Depends:
https://github.com/OCA/storage/pull/435
https://github.com/OCA/storage/pull/434
https://github.com/OCA/storage/pull/438
Result:
Product Test has 2 variants and media file config with each variant
In each variant we has specific medias

