Manual fixes for PR #12642: #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsantiago
force-pushed
the
buildah_bud_fixes
branch
from
ecfe42a to
1b6861c
Compare
- reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip two failing tests that I don't know how to fix: a) --unsetenv is not passed on to buildah (should be easy) b) something manifest-related - skip a bunch more podman-remote tests. Filed an issue for one of them (containers#12838), the others may not be fixable. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
buildah_bud_fixes
branch
from
1b6861c to
267e993
Compare
|
I think I have a fix for a and b. For the other ones I take this patch thanks. |
|
The patch as it stands now includes a lot more fixes than just a and b; there are new skips for podman-remote issues. (They are mentioned in the commit message, but I did not update the github description). Anyhow, all I did was give you a starting point. Thank you for following up with it. |
Luap99
pushed a commit
that referenced
this pull request
Jan 24, 2022
Signed-off-by: Daniel J Walsh <[email protected]>
Luap99
pushed a commit
that referenced
this pull request
Jan 24, 2022
Fix #2 for compat commit handling of --changes
Luap99
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Use vfkit command line assembly * Inject ignition file into guest using http over vsock * Ready notification through use of vsock [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) --unsetenv is not passed on to buildah (should be easy)
b) something manifest-related
Signed-off-by: Ed Santiago [email protected]