podman-remote build, with dockerignore, unexpected (wrong) diagnostic

[edsantiago]

containers/buildah#3576 added an error message and a test for it. This is failing in podman-remote (not podman).

The error emitted by buildah and regular podman:

Error: error building at STEP "COPY test1.txt /upload/test1.txt": 
   no items matching glob "[SOURCEPATH]/bud/dockerignore3/test1.txt" copied
   (1 filtered out using [SOURCEPATH]/bud/dockerignore3/.dockerignore):
    no such file or directory

The error emitted by podman-remote:

Error: error building at STEP "COPY test1.txt /upload/test1.txt":
    checking on sources under "/var/tmp/libpod_builder317490355/build":
    copier: stat: "/test1.txt": no such file or directory

(line breaks added for readability)

[vrothberg]

I'll take a look. Thanks for opening an issue, @edsantiago!

[vrothberg]

Ah, OK.

Since #8374, the remote client is parsing the ignore files and excludes matches from being tar'ed up. This explains the stat error: the file is really not there.

Not sure if we should massage the test OR if we should send the entire context over and let the server exclude the files.

@baude @rhatdan WDYT?

[rhatdan]

I think the test should be massaged.

[rhatdan]

As long as podman --remote build is doing what is supposed to.

[vrothberg]

As long as podman --remote build is doing what is supposed to.

I am not entirely sure if the context should be pre-processed on the client side. @jwhonce WDYT?

[rhatdan]

The issue would then be sending files over that are not needed, so you are wasting bandwidth. But then again, the excludes also have to happen when you call in with the API.

[jwhonce]

@vrothberg I put the pre-processing on the client to not waste bandwidth. Otherwise there is the risk of copying a huge file to the server and then ignoring it.

@rhatdan podman-py processes the ignores on the client.

[rhatdan]

Works for me.

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[rhatdan]

@jwhonce @edsantiago @vrothberg Where are with this one?

[edsantiago]

The test is currently disabled in podman:

podman/test/buildah-bud/apply-podman-deltas

Lines 196 to 197 in c39dffe

	skip_if_remote "Podman #12838: different error messages" \
	"bud with .dockerignore #2"

Although I have provisions in apply-podman-deltas to change the expected error message, I don't have any mechanism to do so only for podman-remote. I'm not especially keen on adding that complexity. If the team's recommendation is to live with that new changed error message, I would suggest just keeping the test as skipped in podman. (But will implement change-error-if-remote or whatever the team recommends)

[rhatdan]

I think we can live with the difference and should close this issue.

[vrothberg]

I think we can live with the difference and should close this issue.

OK