feat(Text): Support formatting and emojis in fromAttributed
#615
+209
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of attributed text to add support for formatting (bold, italics, strikethrough) and emojis (custom ones and unicode ones). To avoid breaking changes, I took the approach of translating the new response as closely as possible to the existing classes and properties, so for anyone with existing code to handle
TextRun
s andEmojiRun
s this should just work.This currently only handles the
styleRuns
,commandRuns
andattachmentRuns
, however adding support for thedecoratedRuns
(only seen them used to add a grey "pill" around some links in video descriptions), shouldn't be too difficult with the way this is designed.Examples:
To test the two comment use cases, you will need to use #614 too, so that it can handle the new comment nodes.
P.S. The way YouTube's attributed text works seems very similar to Apple's
NSAttributedString
/NSMutableAttributedString
classes, so it seems likely that this may have originally been designed for the iOS client.